Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============8107856507845551838=="
MIME-Version: 1.0
Subject: Re: Review Request 39720: Alerts: Rename "Ambari Agent Disk Usage"
 alert
From: "Vitalyi Brodetskyi" <vbrodetskyi@hortonworks.com>
To: "Vitalyi Brodetskyi" <vbrodetskyi@hortonworks.com>
Cc: "Andrew Onischuk" <aonishuk@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Thu, 29 Oct 2015 15:34:15 -0000
Message-ID: <20151029153415.22462.50401@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Vitalyi Brodetskyi" <noreply@reviews.apache.org>
References: <20151029153026.22462.32352@reviews.apache.org>
In-Reply-To: <20151029153026.22462.32352@reviews.apache.org>
Reply-To: "Vitalyi Brodetskyi" <vbrodetskyi@hortonworks.com>

--===============8107856507845551838==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


> On Жов. 29, 2015, 3:30 після полудня, Vitalyi Brodetskyi wrote:
> > Ship It!

Please add unit test and please create constant if you are using some mothod more then one time.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39720/#review104432
-----------------------------------------------------------


On Жов. 29, 2015, 3:27 після полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39720/
> -----------------------------------------------------------
> 
> (Updated Жов. 29, 2015, 3:27 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13603
>     https://issues.apache.org/jira/browse/AMBARI-13603
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The alert "Ambari Agent Disk Usage" is causing some confusion for users: what
> does it really indicate. The ambari disk usage alerts are meant to check two
> things: that you have have enough space total and percent free space in
> /usr/hdp for data created by hadoop and for installing versioned RPMs. Total
> free space alerts are something that you’ll probably want to fix since it
> means you have less than a certain amount of total free space left.
> 
> Proposing the change...
> 
> Alert Name:  
> **Host Disk Usage**
> 
> Description:  
> **This host-level alert is triggered if the amount of disk space used at /usr/hdp goes above specific thresholds. The default threshold values are 50% for WARNING and 80% for CRITICAL.**
> 
> 
> Diffs
> -----
> 
>   ambari-server/docs/api/v1/alerts.md f2c50a8 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java a3d3c53 
>   ambari-server/src/main/resources/alerts.json 6a50223 
>   ambari-web/app/assets/data/alerts/alertDefinitions.json 20d83bd 
>   ambari-web/app/assets/data/alerts/alert_instances.json 03ee7ce 
>   ambari-web/app/assets/data/alerts/alert_summary.json bbc8308 
>   ambari-web/test/mappers/alert_instances_mapper_test.js 2432749 
> 
> Diff: https://reviews.apache.org/r/39720/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


--===============8107856507845551838==--