Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7911318558 for ; Tue, 27 Oct 2015 14:58:16 +0000 (UTC) Received: (qmail 76285 invoked by uid 500); 27 Oct 2015 14:58:16 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 76250 invoked by uid 500); 27 Oct 2015 14:58:16 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 76236 invoked by uid 99); 27 Oct 2015 14:58:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2015 14:58:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 798A027A915; Tue, 27 Oct 2015 14:58:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8590724944671923842==" MIME-Version: 1.0 Subject: Re: Review Request 39687: Allow use passwords references in custom actions From: "Vitalyi Brodetskyi" To: "Dmitro Lisnichenko" , "Robert Nettleton" Cc: "Vitalyi Brodetskyi" , "Ambari" Date: Tue, 27 Oct 2015 14:58:15 -0000 Message-ID: <20151027145815.22462.75626@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Vitalyi Brodetskyi" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39687/ X-Sender: "Vitalyi Brodetskyi" References: <20151027134332.22461.53395@reviews.apache.org> In-Reply-To: <20151027134332.22461.53395@reviews.apache.org> Reply-To: "Vitalyi Brodetskyi" X-ReviewRequest-Repository: ambari --===============8590724944671923842== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39687/ ----------------------------------------------------------- (Updated Жов. 27, 2015, 2:58 після полудня) Review request for Ambari, Dmitro Lisnichenko and Robert Nettleton. Bugs: AMBARI-13582 https://issues.apache.org/jira/browse/AMBARI-13582 Repository: ambari Description ------- Added ability to use secret references in custom actions; /api/v1/blueprints and /api/v1/clusters/cl?format=blueprint returns masked passwords. Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java d834731 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 152016a ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 12373f0 ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java 3ed9306 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 6cb6a74 ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java e3ac3e0 ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 279b31f ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 9e8f163 ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java 2b1aeae ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java af8c5e2 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 5bfdebb ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java 9d4163a ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml 1c02e86 Diff: https://reviews.apache.org/r/39687/diff/ Testing ------- mvn clean test Thanks, Vitalyi Brodetskyi --===============8590724944671923842==--