Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DB55918F9A for ; Fri, 23 Oct 2015 15:49:48 +0000 (UTC) Received: (qmail 48165 invoked by uid 500); 23 Oct 2015 15:49:39 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 48134 invoked by uid 500); 23 Oct 2015 15:49:39 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 48105 invoked by uid 99); 23 Oct 2015 15:49:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Oct 2015 15:49:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DE6C5279272; Fri, 23 Oct 2015 15:49:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3636140485658190610==" MIME-Version: 1.0 Subject: Re: Review Request 39549: Allow Monitors/Agents to be configured to communicate with a collector that is behind a VIP From: "Dmytro Sen" To: "Sumit Mohanty" , "Dmitro Lisnichenko" , "Sid Wagle" Cc: "Dmytro Sen" , "Ambari" Date: Fri, 23 Oct 2015 15:49:38 -0000 Message-ID: <20151023154938.1657.85773@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39549/ X-Sender: "Dmytro Sen" References: <20151023143806.1655.44457@reviews.apache.org> In-Reply-To: <20151023143806.1655.44457@reviews.apache.org> Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============3636140485658190610== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39549/ ----------------------------------------------------------- (Updated Окт. 23, 2015, 3:49 п.п.) Review request for Ambari, Dmitro Lisnichenko, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-13521 https://issues.apache.org/jira/browse/AMBARI-13521 Repository: ambari Description ------- Currently the address of the AMS Collector is automatically picked up from the host assignment to the component. When AMS is used in the active-passive configuration then the hostname of the collector should be explicitly specifiable. That way, it can be configured to have the collector traffic flow through the VIP. Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 5d33e22 ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricHostProvider.java a5a7a71 ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java f221dce ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java 85ea575 ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 485128e ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 8b5ec7a ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py 7c68d98 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2 f0a14b6 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 40b18d7 ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py a80ea1e ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 31e80bf ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py da8333a ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py c1f118f ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/config.yaml.j2 460e391 ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/storm-metrics2.properties.j2 060b4fc ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 5a32b73 ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-START/scripts/params.py 093ea38 ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java afd4752 ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProviderTest.java 500eea4 ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProviderTest.java dd7f95d ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaReportPropertyProviderTest.java c7ba4a9 ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 71febc9 ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py c3722c6 ambari-server/src/test/python/stacks/2.0.6/configs/default.json 57365b6 Diff: https://reviews.apache.org/r/39549/diff/ Testing ------- Manually tested + all unit tests passed ---------------------------------------------------------------------- Ran 247 tests in 7.988s OK ---------------------------------------------------------------------- Total run:810 Total errors:0 Total failures:0 OK Thanks, Dmytro Sen --===============3636140485658190610==--