Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============7919693471456621225=="
MIME-Version: 1.0
Subject: Re: Review Request 39318: Blueprints: install for Ranger Components
 (ranger-admin, ranger-usersync, ranger-kms)
From: "Sebastian Toader" <stoader@hortonworks.com>
To: "Laszlo Puskas" <lpuskas@hortonworks.com>,
 "Sumit Mohanty" <smohanty@hortonworks.com>,
 "Sid Wagle" <swagle@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Sebastian Toader" <stoader@hortonworks.com>
Date: Thu, 22 Oct 2015 16:52:37 -0000
Message-ID: <20151022165237.1666.41534@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sebastian Toader" <noreply@reviews.apache.org>
References: <20151021213633.1666.86763@reviews.apache.org>
In-Reply-To: <20151021213633.1666.86763@reviews.apache.org>
Reply-To: "Sebastian Toader" <stoader@hortonworks.com>

--===============7919693471456621225==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39318/
-----------------------------------------------------------

(Updated Oct. 22, 2015, 4:52 p.m.)


Review request for Ambari, Laszlo Puskas, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-13421
    https://issues.apache.org/jira/browse/AMBARI-13421


Repository: ambari


Description
-------

1. Configured role command order such as all ranger plugins are started after ranger admin+ranger user sync are up in order to ensure that plugins if enabled can regsiter with Ranger
2. In the case of Ranger and ranger plugins being installed to different host the ordering described above is not apply as we don't have cluster wide ordering. Modified the library used by plugins to regsiter with ranger such as to fail if ranger is down provided command "retry" is enabled. If command retry is not enabled than keep the original logic which is just log an error and continue with the processing.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py de58976 
  ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py 81658bf 
  ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin.py e4a19aa 
  ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py 0b404a9 
  ambari-server/src/main/java/org/apache/ambari/server/Role.java df60988 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py 36dd07f 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py 6b4dfaa 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py b89eefd 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 6a64b2f 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params.py 36f7983 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py b0f0c3f 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py dc0c087 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/setup_ranger_kafka.py 540bb9a 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py 8fe1028 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py f1319b3 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 570b2b7 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params.py 1e591f4 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py d874ba3 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params.py 5695e83 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/setup_ranger_yarn.py c8b12df 
  ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json 3571a6c 
  ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java be8b073 

Diff: https://reviews.apache.org/r/39318/diff/


Testing
-------

Unit test:

-----------------------------------------------------------------------
Ran 247 tests in 6.472s

OK
----------------------------------------------------------------------
Total run:770
Total errors:0
Total failures:0
OK
StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
Returning DefaultStackAdvisor implementation
StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
Returning XYZ101StackAdvisor implementation
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:04:49.578s
[INFO] Finished at: Wed Oct 14 15:56:27 CEST 2015
[INFO] Final Memory: 39M/1098M
[INFO] ------------------------------------------------------------------------


Manual testing:

1. Deployed 3 node cluster with Ranger, Resource Manager, Namenode on the same host to verify the hoat wide start order. 
2. Deployed 3 node cluster with Ranger and NameNode on different hosts to verify retry logic.


File Attachments
----------------

AMBARI-1342.v1.patch
  https://reviews.apache.org/media/uploaded/files/2015/10/14/8adbd842-7d7a-4b52-801b-85e0e5b42cc0__AMBARI-13421.v1.patch


Thanks,

Sebastian Toader


--===============7919693471456621225==--