Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D3BF118AA4 for ; Thu, 22 Oct 2015 11:49:09 +0000 (UTC) Received: (qmail 68521 invoked by uid 500); 22 Oct 2015 11:49:09 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 68483 invoked by uid 500); 22 Oct 2015 11:49:09 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 68466 invoked by uid 99); 22 Oct 2015 11:49:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Oct 2015 11:49:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F0125278C62; Thu, 22 Oct 2015 11:49:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4119084717125472459==" MIME-Version: 1.0 Subject: Re: Review Request 39519: Create a script to change host names for a stopped cluster From: "Vitalyi Brodetskyi" To: "Myroslav Papirkovskyy" , "Dmitro Lisnichenko" , "Sumit Mohanty" , "Jonathan Hurley" Cc: "Sid Wagle" , "Vitalyi Brodetskyi" , "Ambari" Date: Thu, 22 Oct 2015 11:49:08 -0000 Message-ID: <20151022114908.1666.10546@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Vitalyi Brodetskyi" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39519/ X-Sender: "Vitalyi Brodetskyi" References: <20151022052246.1667.33001@reviews.apache.org> In-Reply-To: <20151022052246.1667.33001@reviews.apache.org> Reply-To: "Vitalyi Brodetskyi" X-ReviewRequest-Repository: ambari --===============4119084717125472459== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On Жов. 22, 2015, 5:22 до полудня, Sid Wagle wrote: > > ambari-server/sbin/ambari-server, line 147 > > > > > > Lets call this update-hostname Renamed to update-host-names > On Жов. 22, 2015, 5:22 до полудня, Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java, line 174 > > > > > > Should there be an option to updated older configurations and not just the selected ones ? Need to discuss this with Sumit. I don't think we need that/ Will ask in jira. > On Жов. 22, 2015, 5:22 до полудня, Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java, line 351 > > > > > > What about config group associatons, are those by id ? There we are using host id. - Vitalyi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/#review103527 ----------------------------------------------------------- On Жов. 22, 2015, 11:46 до полудня, Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39519/ > ----------------------------------------------------------- > > (Updated Жов. 22, 2015, 11:46 до полудня) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Mohanty. > > > Bugs: AMBARI-13507 > https://issues.apache.org/jira/browse/AMBARI-13507 > > > Repository: ambari > > > Description > ------- > > At a high-level we may follow this approach: > Ensure cluster is not kerberized > Assume all services to be stopped (add a check to ensure that services are stopped) > We may also need to check and confirm that there are no commands pending execution - or just mark them as aborted > Update all host names in the database based on the mapping provided (e.g. host1 --> master01.dev.com) > As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade code > Modify all configs to replace the hostnames as needed (not sure if plain search and replace will suffice) > Agents need to be re-configured if ambari-server hostname changes > > > Diffs > ----- > > ambari-server/sbin/ambari-server 1843cd6 > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 702e12d > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 > ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ed68313 > ambari-server/src/main/python/ambari-server.py 88df81a > ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION > ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea > > Diff: https://reviews.apache.org/r/39519/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > > --===============4119084717125472459==--