Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 33ABD1838F for ; Thu, 22 Oct 2015 08:40:10 +0000 (UTC) Received: (qmail 85932 invoked by uid 500); 22 Oct 2015 08:40:10 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 85890 invoked by uid 500); 22 Oct 2015 08:40:10 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 85871 invoked by uid 99); 22 Oct 2015 08:40:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Oct 2015 08:40:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 63616278A7C; Thu, 22 Oct 2015 08:40:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5592288624918615230==" MIME-Version: 1.0 Subject: Re: Review Request 39517: Enable Ranger plugin properties should be validated to have same value as in Ranger service From: "Dmitro Lisnichenko" To: "Jaimin Jetly" Cc: "Dmytro Sen" , "Ambari" Date: Thu, 22 Oct 2015 08:40:09 -0000 Message-ID: <20151022084009.1667.24339@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dmitro Lisnichenko" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39517/ X-Sender: "Dmitro Lisnichenko" References: <20151022083744.1666.53579@reviews.apache.org> In-Reply-To: <20151022083744.1666.53579@reviews.apache.org> Reply-To: "Dmitro Lisnichenko" X-ReviewRequest-Repository: ambari --===============5592288624918615230== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39517/#review103544 ----------------------------------------------------------- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 22, 2015, 11:37 a.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39517/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2015, 11:37 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jaimin Jetly. > > > Bugs: AMBARI-13504 > https://issues.apache.org/jira/browse/AMBARI-13504 > > > Repository: ambari > > > Description > ------- > > This is to detect deviations in Ranger plugin properties for individual services from the central plugin config in Ranger service. > > Base property Derived property stack > ranger-env/ranger-hdfs-plugin-enabled ranger-hdfs-plugin-properties/ranger-hdfs-plugin-enabled HDP-2.2 onwards > ranger-env/ranger-hive-plugin-enabled ranger-hive-plugin-properties/ranger-hive-plugin-enabled HDP-2.2 onwards > ranger-env/ranger-hbase-plugin-enabled ranger-hbase-plugin-properties/ranger-hbase-plugin-enabled HDP-2.2 onwards > ranger-env/ranger-knox-plugin-enabled ranger-knox-plugin-properties/ranger-knox-plugin-enabled HDP-2.2 onwards > ranger-env/ranger-kafka-plugin-enabled ranger-kafka-plugin-properties/ranger-kafka-plugin-enabled HDP-2.3 onwards > ranger-env/ranger-yarn-plugin-enabled ranger-yarn-plugin-properties/ranger-yarn-plugin-enabled HDP-2.3 onwards > ranger-env/ranger-storm-plugin-enabled ranger-storm-plugin-properties/ranger-storm-plugin-enabled HDP-2.2 onwards > > This translates to following behavior on web-ui: > If value of ranger-env/ranger-hdfs-plugin-enabled is false on Ranger smart config page and user changes the value of ranger-hdfs-plugin-properties/ranger-hdfs-plugin-enabled to true on HDFS service page and saves the configuration then it should show validation error saying that the value of ranger-env/ranger-hdfs-plugin-enabled and ranger-hdfs-plugin-properties/ranger-hdfs-plugin-enabled should always be same > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 3db5bfd > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 3192ca2 > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 533808e > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 3362c94 > > Diff: https://reviews.apache.org/r/39517/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > > --===============5592288624918615230==--