Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5DBD318521 for ; Thu, 22 Oct 2015 01:37:23 +0000 (UTC) Received: (qmail 35207 invoked by uid 500); 22 Oct 2015 01:37:23 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 35181 invoked by uid 500); 22 Oct 2015 01:37:23 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 35166 invoked by uid 99); 22 Oct 2015 01:37:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Oct 2015 01:37:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 70F3A2788CA; Thu, 22 Oct 2015 01:37:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0445374807018888038==" MIME-Version: 1.0 Subject: Re: Review Request 39530: Ambari-13513:[trunk][2.1.2] Add cmd option config to spark thrift server From: "Sumit Mohanty" To: "Alejandro Fernandez" , "Sumit Mohanty" Cc: "Judy Nash" , "Ambari" Date: Thu, 22 Oct 2015 01:37:22 -0000 Message-ID: <20151022013722.1667.49762@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sumit Mohanty" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39530/ X-Sender: "Sumit Mohanty" References: <20151021223302.1667.78265@reviews.apache.org> In-Reply-To: <20151021223302.1667.78265@reviews.apache.org> Reply-To: "Sumit Mohanty" X-ReviewRequest-Repository: ambari --===============0445374807018888038== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39530/#review103507 ----------------------------------------------------------- ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/configuration/spark-thrift-cmd-opts-properties.xml (line 21) What we meant is that you can introduce a property spark-thrift-cmd-opts in spark-env.xml and have it contain the value user wants to supply. Then in the scripts you can refer to it as spark_thrift_cmd_opts_properties = str(config['configurations']['spark-env']['spark-thrift-cmd-opts']) - Sumit Mohanty On Oct. 21, 2015, 10:33 p.m., Judy Nash wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39530/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2015, 10:33 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Bugs: AMBARI-13513 > https://issues.apache.org/jira/browse/AMBARI-13513 > > > Repository: ambari > > > Description > ------- > > Ambari-13513:[trunk][2.1.2] Add cmd option config to spark thrift server > > > Diffs > ----- > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 518ba6d > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py 68a395b > ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/configuration/spark-thrift-cmd-opts-properties.xml PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/metainfo.xml 14161b4 > ambari-server/src/test/python/stacks/2.3/SPARK/test_spark_thrift_server.py b3b8235 > ambari-server/src/test/python/stacks/2.3/configs/spark_default.json 9f3fb90 > > Diff: https://reviews.apache.org/r/39530/diff/ > > > Testing > ------- > > 1. Updated Unit Tests > 2. E2E test on HDInsight cluster > > > Thanks, > > Judy Nash > > --===============0445374807018888038==--