Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 473C51809F for ; Thu, 22 Oct 2015 00:04:40 +0000 (UTC) Received: (qmail 14031 invoked by uid 500); 22 Oct 2015 00:04:40 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 13997 invoked by uid 500); 22 Oct 2015 00:04:40 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 13968 invoked by uid 99); 22 Oct 2015 00:04:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Oct 2015 00:04:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 822E22788BC; Thu, 22 Oct 2015 00:04:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6847303523909447378==" MIME-Version: 1.0 Subject: Re: Review Request 39491: AMBARI-13442: stack advisor layout and validations for HAWQ service master components From: "Alexander Denissov" To: "Alejandro Fernandez" , "Mahadev Konar" , "Jayush Luniya" , "Oleksandr Diachenko" , "jun aoki" Cc: "Alexander Denissov" , "Ambari" Date: Thu, 22 Oct 2015 00:04:39 -0000 Message-ID: <20151022000439.1667.21845@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alexander Denissov" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39491/ X-Sender: "Alexander Denissov" References: <20151020191837.1667.18782@reviews.apache.org> In-Reply-To: <20151020191837.1667.18782@reviews.apache.org> Reply-To: "Alexander Denissov" X-ReviewRequest-Repository: ambari --===============6847303523909447378== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39491/ ----------------------------------------------------------- (Updated Oct. 22, 2015, 12:04 a.m.) Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, Mahadev Konar, and Oleksandr Diachenko. Changes ------- updated with code review fix Bugs: AMBARI-13442 https://issues.apache.org/jira/browse/AMBARI-13442 Repository: ambari Description ------- Introduced layout recommendations and validations for Apache HAWQ service master components. Test cases use new test json files for input rather than hardcoding data in the test case directly. Diffs (updated) ----- ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 501517f ambari-server/src/test/python/stacks/2.3/common/hosts-1-host.json PRE-CREATION ambari-server/src/test/python/stacks/2.3/common/hosts-3-hosts.json PRE-CREATION ambari-server/src/test/python/stacks/2.3/common/services-hawq-1-host.json PRE-CREATION ambari-server/src/test/python/stacks/2.3/common/services-hawq-3-hosts.json PRE-CREATION ambari-server/src/test/python/stacks/2.3/common/services-master_ambari_colo-3-hosts.json PRE-CREATION ambari-server/src/test/python/stacks/2.3/common/services-master_standby_colo-3-hosts.json PRE-CREATION ambari-server/src/test/python/stacks/2.3/common/services-nohawq-3-hosts.json PRE-CREATION ambari-server/src/test/python/stacks/2.3/common/services-normal-hawq-3-hosts.json PRE-CREATION ambari-server/src/test/python/stacks/2.3/common/services-normal-nohawq-3-hosts.json PRE-CREATION ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json PRE-CREATION ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py e0c6d28 Diff: https://reviews.apache.org/r/39491/diff/ Testing ------- Added new and ran python unit tests: ---------------------------------------------------------------------- Total run:775 Total errors:0 Total failures:0 OK File Attachments (updated) ---------------- updated with fix https://reviews.apache.org/media/uploaded/files/2015/10/22/b04e7344-e7d7-4577-aa34-d7850f5ef090__AMBARI-13442.patch.1 Thanks, Alexander Denissov --===============6847303523909447378==--