Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9028118F06 for ; Tue, 20 Oct 2015 07:47:52 +0000 (UTC) Received: (qmail 55756 invoked by uid 500); 20 Oct 2015 07:47:43 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 55721 invoked by uid 500); 20 Oct 2015 07:47:42 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 55704 invoked by uid 99); 20 Oct 2015 07:47:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Oct 2015 07:47:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 686D227817C; Tue, 20 Oct 2015 07:47:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3519596499931493436==" MIME-Version: 1.0 Subject: Re: Review Request 39440: RU: Fix hbase snapshot From: "Dmitro Lisnichenko" To: "Alejandro Fernandez" , "Nate Cole" , "Dmytro Grinenko" , "Jonathan Hurley" Cc: "Dmitro Lisnichenko" , "Ambari" Date: Tue, 20 Oct 2015 07:47:42 -0000 Message-ID: <20151020074742.1667.52157@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dmitro Lisnichenko" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39440/ X-Sender: "Dmitro Lisnichenko" References: <20151019220655.32263.30420@reviews.apache.org> In-Reply-To: <20151019220655.32263.30420@reviews.apache.org> Reply-To: "Dmitro Lisnichenko" X-ReviewRequest-Repository: ambari --===============3519596499931493436== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 19, 2015, 10:06 p.m., Jonathan Hurley wrote: > > Caused by: AMBARI-13378. Stop-and-Start Upgrade: Merge feature branch to trunk. (dgrinenko via dlysnichenko) > > > > Looks like a simple matter of adding a new `restore_snapshot` function and renaming the existing one for consistency. Maybe double-check before commit, but patch looks good. Yes, I checked. It's fixed in branch-2.1 - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39440/#review103169 ----------------------------------------------------------- On Oct. 19, 2015, 2:31 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39440/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 2:31 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-13474 > https://issues.apache.org/jira/browse/AMBARI-13474 > > > Repository: ambari > > > Description > ------- > > Looks like someone has changed the function name in hbase script from snapshot() to take_snapshot() but looks like the upgrade pack (HDP 2.2 & 2.3) still reflects old function name. > > https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_upgrade.py#L27 > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml e54f0d8 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8c8db7c > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 08b34be > > Diff: https://reviews.apache.org/r/39440/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > > --===============3519596499931493436==--