Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2025418992 for ; Tue, 20 Oct 2015 04:58:34 +0000 (UTC) Received: (qmail 56497 invoked by uid 500); 20 Oct 2015 04:58:34 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 56465 invoked by uid 500); 20 Oct 2015 04:58:34 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 56450 invoked by uid 99); 20 Oct 2015 04:58:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Oct 2015 04:58:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8119D269FBB; Tue, 20 Oct 2015 04:58:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3231545100210829637==" MIME-Version: 1.0 Subject: Re: Review Request 39468: Ranger User Info tab: All subsequent subsection and their configs should be hidden if Ranger Usersync is disabled From: "Jaimin Jetly" To: "Srimanth Gunturi" , "Gautam Borad" , "Yusaku Sako" Cc: "Ambari" , "Jaimin Jetly" Date: Tue, 20 Oct 2015 04:58:31 -0000 Message-ID: <20151020045831.32264.90689@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jaimin Jetly" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39468/ X-Sender: "Jaimin Jetly" References: <20151020045103.32264.45889@reviews.apache.org> In-Reply-To: <20151020045103.32264.45889@reviews.apache.org> Reply-To: "Jaimin Jetly" X-ReviewRequest-Repository: ambari --===============3231545100210829637== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39468/ ----------------------------------------------------------- (Updated Oct. 20, 2015, 4:58 a.m.) Review request for Ambari, Gautam Borad, Srimanth Gunturi, and Yusaku Sako. Bugs: AMBARI-13481 https://issues.apache.org/jira/browse/AMBARI-13481 Repository: ambari Description ------- All subsequent subsection and their configs should be hidden if Ranger Usersync is disabled. To achive this task visiblity of subsection and subsection-tab is dynamically changed depending upon the condition stated in theme. Diffs (updated) ----- ambari-web/app/mappers/configs/themes_mapper.js 2fc9641 ambari-web/app/models.js 5d5cdd0 ambari-web/app/models/configs/config_condition.js f978424 ambari-web/app/models/configs/theme/sub_section.js 261d3b8 ambari-web/app/models/configs/theme/sub_section_tab.js bf7c015 ambari-web/app/models/configs/theme/theme_condition.js PRE-CREATION ambari-web/app/views/common/configs/service_config_layout_tab_view.js f7a376d ambari-web/app/views/common/configs/widgets/config_widget_view.js b3e806f Diff: https://reviews.apache.org/r/39468/diff/ Testing ------- Tested manually on a cluster. Verified that all ambari-web unit tests passes: 9391 tests complete (11 seconds) 94 tests pending Thanks, Jaimin Jetly --===============3231545100210829637==--