Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E4A0618DEA for ; Wed, 14 Oct 2015 17:55:49 +0000 (UTC) Received: (qmail 13200 invoked by uid 500); 14 Oct 2015 17:55:40 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 13165 invoked by uid 500); 14 Oct 2015 17:55:40 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 13148 invoked by uid 99); 14 Oct 2015 17:55:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Oct 2015 17:55:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 86C9A2A2B2A; Wed, 14 Oct 2015 17:55:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4049002260364036057==" MIME-Version: 1.0 Subject: Re: Review Request 39277: Improve update repo custom action From: "Alejandro Fernandez" To: "Sumit Mohanty" , "Dmitro Lisnichenko" Cc: "Alejandro Fernandez" , "Vitalyi Brodetskyi" , "Ambari" Date: Wed, 14 Oct 2015 17:55:38 -0000 Message-ID: <20151014175538.1509.99405@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alejandro Fernandez" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39277/ X-Sender: "Alejandro Fernandez" References: <20151013162032.28635.46263@reviews.apache.org> In-Reply-To: <20151013162032.28635.46263@reviews.apache.org> Reply-To: "Alejandro Fernandez" X-ReviewRequest-Repository: ambari --===============4049002260364036057== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39277/#review102668 ----------------------------------------------------------- ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java (line 436) Can you add some doc to this function? - Alejandro Fernandez On Oct. 13, 2015, 4:20 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39277/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 4:20 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty. > > > Bugs: AMBARI-13405 > https://issues.apache.org/jira/browse/AMBARI-13405 > > > Repository: ambari > > > Description > ------- > > We need the ability to continue executing commands even if some calls fail (again, I think install package has the ability) > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/Role.java c684981 > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 564a288 > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java eed4379 > > Diff: https://reviews.apache.org/r/39277/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > > --===============4049002260364036057==--