Return-Path: 
 <dev-return-90149-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id EBD361833C
	for <apmail-ambari-dev-archive@www.apache.org>;
 Tue, 13 Oct 2015 17:31:22 +0000 (UTC)
Received: (qmail 48026 invoked by uid 500); 13 Oct 2015 17:31:16 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 47996 invoked by uid 500); 13 Oct 2015 17:31:16 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 47983 invoked by uid 99); 13 Oct 2015 17:31:16 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Oct 2015 17:31:16 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 9F219277225;
	Tue, 13 Oct 2015 17:31:14 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============8006917359652769683=="
MIME-Version: 1.0
Subject: Re: Review Request 39281: Rolling Upgrade: Internal Server Error Due
 To XML Binding Tasks To Groupings
From: "Alejandro Fernandez" <afernandez@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Date: Tue, 13 Oct 2015 17:31:14 -0000
Message-ID: <20151013173114.1509.79765@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Alejandro Fernandez" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/39281/
X-Sender: "Alejandro Fernandez" <noreply@reviews.apache.org>
References: <20151013172349.28635.63507@reviews.apache.org>
In-Reply-To: <20151013172349.28635.63507@reviews.apache.org>
Reply-To: "Alejandro Fernandez" <afernandez@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============8006917359652769683==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39281/#review102482
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Oct. 13, 2015, 5:23 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39281/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 5:23 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-13406
>     https://issues.apache.org/jira/browse/AMBARI-13406
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ```
> 2015-10-13 17:22:13,946 ERROR [qtp-client-87 - /api/v1/clusters/c1/upgrades] handlers.BaseManagementHandler (CreateHandler.java:persist(65)) - Caught a runtime exception while attempting to create a resource
> java.lang.ClassCastException: org.apache.ambari.server.state.stack.upgrade.RestartGrouping cannot be cast to org.apache.ambari.server.state.stack.upgrade.Task
> 	at org.apache.ambari.server.state.stack.upgrade.Grouping$DefaultBuilder.add(Grouping.java:111)
> ```
> 
> Caused by a grouping being bound to task. We need to change:
>         <upgrade>
>           <task xsi:type="restart" />
>         </upgrade>
> to
>         <upgrade>
>           <task xsi:type="restart-task" />
>         </upgrade>
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 810423d 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 2c7cc7c 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 4f57978 
>   ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_skip_failures.xml 467e63a 
> 
> Diff: https://reviews.apache.org/r/39281/diff/
> 
> 
> Testing
> -------
> 
> Performed a rolling upgrade of a ZK cluster. Running through tests now as well (actually, mostly looking for disabled tests that can be turned back on).
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


--===============8006917359652769683==--