Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D137E18F86 for ; Mon, 12 Oct 2015 15:07:25 +0000 (UTC) Received: (qmail 8641 invoked by uid 500); 12 Oct 2015 15:07:25 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 8604 invoked by uid 500); 12 Oct 2015 15:07:25 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 8590 invoked by uid 99); 12 Oct 2015 15:07:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Oct 2015 15:07:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BE12C1DD7DC; Mon, 12 Oct 2015 15:07:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1293743674807341802==" MIME-Version: 1.0 Subject: Re: Review Request 39234: Unable to set user value for kafka-broker/kafka.metrics.reporters From: "Dmitro Lisnichenko" To: "Dmitro Lisnichenko" , "Vitalyi Brodetskyi" Cc: "Dmytro Sen" , "Ambari" Date: Mon, 12 Oct 2015 15:07:23 -0000 Message-ID: <20151012150723.28636.76916@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dmitro Lisnichenko" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39234/ X-Sender: "Dmitro Lisnichenko" References: <20151012145017.1509.80293@reviews.apache.org> In-Reply-To: <20151012145017.1509.80293@reviews.apache.org> Reply-To: "Dmitro Lisnichenko" X-ReviewRequest-Repository: ambari --===============1293743674807341802== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39234/#review102258 ----------------------------------------------------------- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 12, 2015, 2:50 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39234/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2015, 2:50 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi. > > > Bugs: AMBARI-13390 > https://issues.apache.org/jira/browse/AMBARI-13390 > > > Repository: ambari > > > Description > ------- > > whatever user set as value for kafka.metrics.reporters , it's overridden by ambari agent > /var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py:57 > kafka_server_config['kafka.metrics.reporters'] = params.kafka_metrics_reporters > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java dcdbb85 > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-broker.xml 1cbfade > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py 4d28c41 > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 0a55504 > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java a54dee2 > > Diff: https://reviews.apache.org/r/39234/diff/ > > > Testing > ------- > > Unit tests passed. > Manually tested upgrade from 2.1.2 to 2.1.3 > > > Thanks, > > Dmytro Sen > > --===============1293743674807341802==--