Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============7210890069947554104=="
MIME-Version: 1.0
Subject: Re: Review Request 39001: Class not found exception while running
 step
 "ambari-server upgradestack HDP-2.3" for upgrade path 2.2 -> 2.3.2 Amabri
 DB is Oracle
From: "Andrew Onischuk" <aonishuk@hortonworks.com>
To: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>,
 "Vitalyi Brodetskyi" <vbrodetskyi@hortonworks.com>
Cc: "Andrew Onischuk" <aonishuk@hortonworks.com>,
 "Dmytro Sen" <dsen@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Thu, 08 Oct 2015 10:21:44 -0000
Message-ID: <20151008102144.31883.95186@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Andrew Onischuk" <noreply@reviews.apache.org>
References: <20151008093053.31883.85954@reviews.apache.org>
In-Reply-To: <20151008093053.31883.85954@reviews.apache.org>
Reply-To: "Andrew Onischuk" <aonishuk@hortonworks.com>

--===============7210890069947554104==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39001/#review101891
-----------------------------------------------------------


ambari-server/src/main/python/ambari_server/serverClassPath.py (line 102)
<https://reviews.apache.org/r/39001/#comment159394>

    It's not obvious that get_full_ambari_classpath method can return quoted classpath. Can return it here unquoted and then simply decorate with quote_bash_args(..) which will also catch other espace symbols like !'"$ in path.


- Andrew Onischuk


On Oct. 8, 2015, 9:30 a.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39001/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 9:30 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13283
>     https://issues.apache.org/jira/browse/AMBARI-13283
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> As part of upgrade the step "ambari-server upgradestack HDP-2.3" Failed with the exception
> 29 Sep 2015 10:51:23,202 INFO main ControllerModule:187 - Detected ORACLE as the database type from the JDBC URL
> 29 Sep 2015 10:51:26,129 INFO main ControllerModule:564 - Binding and registering notification dispatcher class org.apache.ambari.server.notifications.dispatchers.SNMPDispatcher
> 29 Sep 2015 10:51:26,132 INFO main ControllerModule:564 - Binding and registering notification dispatcher class org.apache.ambari.server.notifications.dispatchers.AlertScriptDispatcher
> 29 Sep 2015 10:51:26,143 INFO main ControllerModule:564 - Binding and registering notification dispatcher class org.apache.ambari.server.notifications.dispatchers.EmailDispatcher
> 29 Sep 2015 10:51:29,225 ERROR main DBAccessorImpl:102 - Error while creating database accessor
> java.lang.ClassNotFoundException: oracle.jdbc.driver.OracleDriver
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari-server.py 7d46f69 
>   ambari-server/src/main/python/ambari_server/serverClassPath.py PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py bc9823c 
>   ambari-server/src/main/python/ambari_server/serverSetup.py b3e6e21 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 3545b65 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 9b88bef 
>   ambari-server/src/main/python/ambari_server_main.py 4f532f3 
>   ambari-server/src/test/python/TestAmbariServer.py 056dac8 
>   ambari-server/src/test/python/TestServerClassPath.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39001/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


--===============7210890069947554104==--