Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8E5AA18104 for ; Tue, 6 Oct 2015 23:53:10 +0000 (UTC) Received: (qmail 80368 invoked by uid 500); 6 Oct 2015 23:53:10 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 80337 invoked by uid 500); 6 Oct 2015 23:53:10 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 80319 invoked by uid 99); 6 Oct 2015 23:53:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Oct 2015 23:53:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5FAB9288186; Tue, 6 Oct 2015 23:53:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3890441150140493240==" MIME-Version: 1.0 Subject: Re: Review Request 39052: Ambari-server upgrade and RU update hbase bucket cache setting incorrectly From: "Sid Wagle" To: "Sid Wagle" , "Myroslav Papirkovskyy" , "Dmitro Lisnichenko" , "Sumit Mohanty" , "Jonathan Hurley" Cc: "Vitalyi Brodetskyi" , "Ambari" Date: Tue, 06 Oct 2015 23:53:09 -0000 Message-ID: <20151006235309.31883.42822@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sid Wagle" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39052/ X-Sender: "Sid Wagle" References: <20151006171322.31884.10890@reviews.apache.org> In-Reply-To: <20151006171322.31884.10890@reviews.apache.org> Reply-To: "Sid Wagle" X-ReviewRequest-Repository: ambari --===============3890441150140493240== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39052/#review101716 ----------------------------------------------------------- ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java (line 135) How is MaxDirectSize added with this patch? Is it present in the stack def? - Sid Wagle On Oct. 6, 2015, 5:13 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39052/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2015, 5:13 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-13325 > https://issues.apache.org/jira/browse/AMBARI-13325 > > > Repository: ambari > > > Description > ------- > > PROBLEM: Ambari update the below setting in hbase-site: > hbase.bucketcache.ioengine=offheap > hbase.bucketcache.percentage.in.combinedcache= > hbase.bucketcache.size=10240 > But there is no setting in hbase-env for > -XX:MaxDirectMemorySize > so when restart HBase Region server, it fails > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 62cd868 > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 7caf50e > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java b6e0ccb > > Diff: https://reviews.apache.org/r/39052/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > > --===============3890441150140493240==--