Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7EE4518CB4 for ; Mon, 5 Oct 2015 14:19:18 +0000 (UTC) Received: (qmail 68315 invoked by uid 500); 5 Oct 2015 14:19:18 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 68280 invoked by uid 500); 5 Oct 2015 14:19:18 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 68266 invoked by uid 99); 5 Oct 2015 14:19:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Oct 2015 14:19:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 08BCF28D1D1; Mon, 5 Oct 2015 14:19:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9018890034733714614==" MIME-Version: 1.0 Subject: Re: Review Request 38994: Agent instance memory footprint likely gradually growing From: "Sumit Mohanty" To: "Dmitro Lisnichenko" Cc: "Andrew Onischuk" , "Sumit Mohanty" , "Ambari" Date: Mon, 05 Oct 2015 14:19:17 -0000 Message-ID: <20151005141917.31884.34268@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sumit Mohanty" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38994/ X-Sender: "Sumit Mohanty" References: <20151005091040.31883.28469@reviews.apache.org> In-Reply-To: <20151005091040.31883.28469@reviews.apache.org> Reply-To: "Sumit Mohanty" X-ReviewRequest-Repository: ambari --===============9018890034733714614== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38994/#review101474 ----------------------------------------------------------- ambari-common/src/main/python/resource_management/core/logger.py (line 41) The two returns do not return the same data. Is that OK? Also, it is possible for the second call to return before logger is properly initialized - before calls to setLevel/addHandler are called. - Sumit Mohanty On Oct. 5, 2015, 9:10 a.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38994/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2015, 9:10 a.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-13307 > https://issues.apache.org/jira/browse/AMBARI-13307 > > > Repository: ambari > > > Description > ------- > > Noticed about 1.5 G of resident memory for the agents on a cluster that is running for about a month. > Which is an obvious memory leak. > > > Diffs > ----- > > ambari-common/src/main/python/resource_management/core/logger.py 7642c6d > > Diff: https://reviews.apache.org/r/38994/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > > --===============9018890034733714614==--