Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Subject: Re: Review Request 37626: AMBARI-12486 Enabling namenode HA fails
 when non default ports are used
MIME-Version: 1.0
From: Jaimin Jetly <jaimin@hortonworks.com>
To: Alejandro Fernandez <afernandez@hortonworks.com>, Yusaku Sako
	<yusaku@hortonworks.com>, Ambari <dev@ambari.apache.org>, "Juanjo  Marron"
	<jmarron@us.ibm.com>
Thread-Topic: Review Request 37626: AMBARI-12486 Enabling namenode HA fails
 when non default ports are used
Thread-Index: AQHQ9k5Itrt9LriPjEOFLnBFEC+vpJ5r7xsAgAAXagD//41DWA==
Date: Wed, 14 Oct 2015 20:38:55 +0000
Message-ID: <1444855135092.84337@hortonworks.com>
References: 
 <20151014190444.1509.79051@reviews.apache.org>,<20151014202832.28635.56177@reviews.apache.org>
In-Reply-To: <20151014202832.28635.56177@reviews.apache.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Patch has been committed to trunk and branch-2.1.3

-- Thanks
    Jaimin
________________________________________
From: Juanjo  Marron <noreply@reviews.apache.org> on behalf of Juanjo  Marr=
on <jmarron@us.ibm.com>
Sent: Wednesday, October 14, 2015 1:28 PM
To: Alejandro Fernandez; Yusaku Sako; Jaimin Jetly
Cc: Juanjo  Marron; Ambari
Subject: Re: Review Request 37626: AMBARI-12486 Enabling namenode HA fails =
when non default ports are used

> On Oct. 14, 2015, 7:04 p.m., Jaimin Jetly wrote:
> > Ship It!

Great! Thanks Jaimin.
I dont have privileges to commit it. Could someone ship it for me, please?


- Juanjo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37626/#review102689
-----------------------------------------------------------


On Sept. 23, 2015, 10:21 p.m., Juanjo  Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37626/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 10:21 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Yusaku =
Sako.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enabling HA code may not read correct properties.
> When HDFS and ZOOKEEPER ports are changed (different than default values =
ZK: 2181 and HDFS: 8020,50070,50470), HA wizard menus is still showing the =
ones by default and HA namenode fails with connection errors.
> Checked the source code for the Step 3 in namenode HA wizard (ambari-web/=
app/controllers/main/admin/highAvailability/nameNode/step3_controller.js)
> The node address is looked from the configuration but ports hardcoded ins=
tead of the new once modified on the installation wizard, ex:
> ...
> this.setConfigInitialValue(config,'qjournal://' + journalNodeHosts[0] + '=
:8485;' + journalNodeHosts[1] + ':8485;' + journalNodeHosts[2] + ':8485/' +=
 nameServiceId);
> this.setConfigInitialValue(config,zooKeeperHosts[0] + ':2181,' + zooKeepe=
rHosts[1] + ':2181,' + zooKeeperHosts[2] + ':2181');
> ...
> This is a bug that should be fixed.
>
>
> Diffs
> -----
>
>   ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_c=
ontroller.js cf2d971
>
> Diff: https://reviews.apache.org/r/37626/diff/
>
>
> Testing
> -------
>
> Manual test on fresh installation
>
>
> Thanks,
>
> Juanjo  Marron
>
>