ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Review Request 39773: Various metrics show no data available - when HA enabled
Date Thu, 29 Oct 2015 21:01:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39773/
-----------------------------------------------------------

Review request for Ambari, Dmytro Sen, Mahadev Konar, and Myroslav Papirkovskyy.


Bugs: AMBARI-13641
    https://issues.apache.org/jira/browse/AMBARI-13641


Repository: ambari


Description
-------

The Metrics Cache introduced in Ambari stores the metrics result in an HashMap with metric
name as the key. This results in a problem when the same request needs to fetch metrics for
both the Namenodes or both the Resourcemangers. The last result gets cached.

*Note*: Workaround for this is to disable cache in 2.1.2 by setting this property in ambari.properties
file : server.timeline.metrics.cache.disabled = true


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCache.java
9e343e3 
  ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java
e8a2aef 
  ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricsCacheValue.java
4b22898 
  ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheTest.java
7391e15 

Diff: https://reviews.apache.org/r/39773/diff/


Testing
-------

Manaully verified.
Relevant unti test pass.


Thanks,

Sid Wagle


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message