ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 39737: Add unit tests for change hostname functionality
Date Thu, 29 Oct 2015 06:57:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39737/#review104396
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java (line 150)
<https://reviews.apache.org/r/39737/#comment162671>

    Could have default visibility (unit test is in the same package)


- Dmitro Lisnichenko


On Oct. 28, 2015, 11:57 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39737/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2015, 11:57 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13617
>     https://issues.apache.org/jira/browse/AMBARI-13617
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add unit tests and some fixes for hostname update functionality.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java 672cd4e

>   ambari-server/src/main/python/ambari_server/hostUpdate.py bfd6651 
>   ambari-server/src/test/java/org/apache/ambari/server/update/HostUpdateHelperTest.java
PRE-CREATION 
>   ambari-server/src/test/python/TestAmbariServer.py 034aed6 
> 
> Diff: https://reviews.apache.org/r/39737/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message