ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "DIPAYAN BHOWMICK" <dipayan.bhowm...@gmail.com>
Subject Re: Review Request 39681: Hive View query error, should use GetOperationStatus thrift api to verify if hive query is completed successfully
Date Wed, 28 Oct 2015 15:55:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39681/#review104299
-----------------------------------------------------------

Ship it!


Ship It!

- DIPAYAN BHOWMICK


On Oct. 27, 2015, 9:30 a.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39681/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2015, 9:30 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-13575
>     https://issues.apache.org/jira/browse/AMBARI-13575
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Hive view gives error while fetching the results. Although the results are available
through beeline.
> Root Cause : hive view trying to fetch results without checking the status of the hive
query completed or not.
> In this Patch : 
> The /results REST api first checks the status of hive query through thrift api and then
sends the results.
> 
> JobController JobControllerImpl : added getStatus() which returns the Hive query status
via thrift api
> JobService : returns retry to client if the job is running, pending, initialized or unknown.
for other states it tries to fetch the results.
> results.js : handles retries in a recursive fashion.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
526f13f 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobController.java
a25f7d4 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobControllerImpl.java
32d64ec 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index/history-query/results.js
5c7ded2 
> 
> Diff: https://reviews.apache.org/r/39681/diff/
> 
> 
> Testing
> -------
> 
> Only manual testing done. Error could not be reproduce on the dev environment.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message