ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 39700: RU & EU: Allow set-current to force a version into the db
Date Wed, 28 Oct 2015 11:57:00 GMT


> On Oct. 28, 2015, 5:04 a.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/python/ambari_server/serverUpgrade.py, line 415
> > <https://reviews.apache.org/r/39700/diff/1/?file=1109780#file1109780line415>
> >
> >     I think in python we may use boolean type directly instead of strings here

I had actually written the server side first, and that was giving me strings no matter what
I provided for the API call.  I'll make it boolean for clarity hoping one day the API does
it right :)


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39700/#review104266
-----------------------------------------------------------


On Oct. 27, 2015, 5:08 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39700/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2015, 5:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-13591
>     https://issues.apache.org/jira/browse/AMBARI-13591
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> {{ambari-server --set-current}} should have an additional option to set a version to
current.  Existing functionality takes the information passed in and calls the Finalize action.
 This attempts to go through the framework and "cleanly" make sure all the versions are correct
by applying the same logic as finalize.
> 
> Add a {{--force}} option to do the db work directly without going through the finalize
action, modeled after what the RU magician does.  If work is small enough, possible backport
to 2.1.3.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
2a1431d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java
8d4c5ee 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentDesiredStateDAO.java
2620c8c 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java
d5707be 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java ad617af

>   ambari-server/src/main/python/ambari-server.py 2fae1ee 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 7048812 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
1819ef9 
>   ambari-server/src/test/python/TestServerUpgrade.py 7ef74b2 
> 
> Diff: https://reviews.apache.org/r/39700/diff/
> 
> 
> Testing
> -------
> 
> Manual verification.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message