ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 39589: Express Upgrade: stages for non-existing services/components are also scheduled.
Date Tue, 27 Oct 2015 14:07:41 GMT


> On Oct. 27, 2015, 2:11 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java,
line 208
> > <https://reviews.apache.org/r/39589/diff/2/?file=1107574#file1107574line208>
> >
> >     Null or empty

It's the same logic as it was before refactoring. Just moved out getMasterAndHosts() call


> On Oct. 27, 2015, 2:11 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java,
line 153
> > <https://reviews.apache.org/r/39589/diff/2/?file=1107574#file1107574line153>
> >
> >     Null or empty, right?

According to getMasterAndHosts() code, it returns null in this case, so emty set should not
be possible. I added the emty() check for the case of future code change.


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39589/#review104161
-----------------------------------------------------------


On Oct. 27, 2015, 4:06 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39589/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2015, 4:06 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and
Nate Cole.
> 
> 
> Bugs: AMBARI-13541
>     https://issues.apache.org/jira/browse/AMBARI-13541
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During EU, stages for non-existing services/components are also scheduled. So EU fails
on changing configs for missing services
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
6137285 
>   ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
6d345a5 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
abf142e 
>   ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/ClusterGroupingTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39589/diff/
> 
> 
> Testing
> -------
> 
> Checked EU 2.1->2.3 with not all services installed, verified that configs are changed
and only tasks for existing services are generated. 
> 
> Patch does not introduce new unit failures.
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message