ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gautam Borad" <gbo...@gmail.com>
Subject Re: Review Request 39627: Add Admin, usersync and Audit tab in Ranger theme for Ranger 0.4.0 (HDP-2.2 stack)
Date Tue, 27 Oct 2015 07:04:21 GMT


> On Oct. 26, 2015, 7:51 a.m., Gautam Borad wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml,
line 219
> > <https://reviews.apache.org/r/39627/diff/2/?file=1106530#file1106530line219>
> >
> >     This is not required for Stack 2.2
> >     We should move this to 2.3
> 
> Jaimin Jetly wrote:
>     Should SYNC_LDAP_BIND_DN and SYNC_LDAP_BIND_PASSWORD be shown always for HDP-2.2
? 
>     This is not the case for HDP-2.3 and I was trying to repicate the same behavior in
HDP-2.2 as it is in HDP-2.3

SYNC_LDAP_BIND_DN and SYNC_LDAP_BIND_PASSWORD are present in HDP-2.2 in usersync-properties.xml
and is used by Ranger Usersync.
If smart configs will be used for 2.3 stack only, not sure how this property will behave for
2.2


- Gautam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39627/#review103987
-----------------------------------------------------------


On Oct. 26, 2015, 6:49 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39627/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2015, 6:49 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Richard Zang, Srimanth Gunturi, Xi Wang, and
Yusaku Sako.
> 
> 
> Bugs: AMBARI-13557
>     https://issues.apache.org/jira/browse/AMBARI-13557
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add Admin, usersync and Audit tab in Ranger theme for Ranger 0.4.0 (HDP-2.2 stack)
> Make stack advsior changes to set service related ranger properties in HDP-2.2 stacks
automatically
> Patch also resolves a bug where JDBC URL value for Oracle database had missing '/'
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml
f530330 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml
59b7d9e 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml
742e971 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py d62f44b

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml
77fdc1a 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml
68da87e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml
3eb3c0f 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/themes/theme_version_1.json
23f1a0b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml
e2ff6fe 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml
5d7f7ce 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml
0f1c837 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json
187942c 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 464f9cc 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py ee21cdb 
>   ambari-server/src/test/python/unitTests.py fe9b60a 
>   ambari-web/app/data/HDP2.2/site_properties.js 9235dfa 
>   ambari-web/app/data/HDP2.3/site_properties.js 9f64912 
> 
> Diff: https://reviews.apache.org/r/39627/diff/
> 
> 
> Testing
> -------
> 
> Tested on a live cluster.
> Verifeid that ambari-web and python unit tests passes successfully:
> 
>   Existing ambari-web unit tests with the patch:
> 
>   10142 tests complete (11 seconds)
>   104 tests pending
>   
>   
>   
>   Python unit tests covering stack advisor changes:
>   
>   ----------------------------------------------------------------------
> Ran 236 tests in 6.878s
> 
> OK
> ----------------------------------------------------------------------
> Total run:827
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message