ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Re: Review Request 39549: Allow Monitors/Agents to be configured to communicate with a collector that is behind a VIP
Date Fri, 23 Oct 2015 16:52:19 GMT


> On Окт. 23, 2015, 4:48 п.п., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java,
line 397
> > <https://reviews.apache.org/r/39549/diff/4/?file=1105014#file1105014line397>
> >
> >     Why not check one of the COLLECTOR SCH is live ?

If clusterMetricserverVipHost not set - use previous approach. If clusterMetricserverVipHost
is set it can be any virtual ip, isHostLive works only with internal fqdn.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39549/#review103796
-----------------------------------------------------------


On Окт. 23, 2015, 3:49 п.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39549/
> -----------------------------------------------------------
> 
> (Updated Окт. 23, 2015, 3:49 п.п.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-13521
>     https://issues.apache.org/jira/browse/AMBARI-13521
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently the address of the AMS Collector is automatically picked up from the host assignment
to the component. When AMS is used in the active-passive configuration then the hostname of
the collector should be explicitly specifiable. That way, it can be configured to have the
collector traffic flow through the VIP.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
5d33e22 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricHostProvider.java
a5a7a71 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
f221dce 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java
85ea575 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
485128e 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
8b5ec7a 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
7c68d98 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
f0a14b6 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
40b18d7 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
a80ea1e 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
31e80bf 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py
da8333a 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
c1f118f 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/config.yaml.j2
460e391 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/storm-metrics2.properties.j2
060b4fc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
5a32b73 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-START/scripts/params.py
093ea38 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java
afd4752 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProviderTest.java
500eea4 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProviderTest.java
dd7f95d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaReportPropertyProviderTest.java
c7ba4a9 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
71febc9 
>   ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py c3722c6 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 57365b6 
> 
> Diff: https://reviews.apache.org/r/39549/diff/
> 
> 
> Testing
> -------
> 
> Manually tested + all unit tests passed
> 
> ----------------------------------------------------------------------
> Ran 247 tests in 7.988s
> 
> OK
> ----------------------------------------------------------------------
> Total run:810
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message