ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Judy Nash" <judyn...@microsoft.com>
Subject Re: Review Request 39530: Ambari-13513:[trunk][2.1.2] Add cmd option config to spark thrift server
Date Thu, 22 Oct 2015 01:26:36 GMT


> On Oct. 22, 2015, 12:59 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/configuration/spark-thrift-cmd-opts-properties.xml,
line 21
> > <https://reviews.apache.org/r/39530/diff/1/?file=1102701#file1102701line21>
> >
> >     ditto.
> >     spark-env file already exists, so can add another property there, "spark_thrift_content"
(or something like it)

Spark-env.sh doesn't have any spark thrift server property that can be used for this today.
Using spark-env will require an apache spark commit. 

Can't read the property at runtime when kicking off ./start-thriftserver.sh neither, as spark-env.sh
is not loaded until later at spark-class.sh. 

Are there other ways to make the property value consumable by ambari that I have not thought
of?


- Judy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39530/#review103500
-----------------------------------------------------------


On Oct. 21, 2015, 10:33 p.m., Judy Nash wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39530/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 10:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13513
>     https://issues.apache.org/jira/browse/AMBARI-13513
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari-13513:[trunk][2.1.2] Add cmd option config to spark thrift server
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py
518ba6d 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py
68a395b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/configuration/spark-thrift-cmd-opts-properties.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/metainfo.xml 14161b4

>   ambari-server/src/test/python/stacks/2.3/SPARK/test_spark_thrift_server.py b3b8235

>   ambari-server/src/test/python/stacks/2.3/configs/spark_default.json 9f3fb90 
> 
> Diff: https://reviews.apache.org/r/39530/diff/
> 
> 
> Testing
> -------
> 
> 1. Updated Unit Tests 
> 2. E2E test on HDInsight cluster
> 
> 
> Thanks,
> 
> Judy Nash
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message