ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Denissov" <adenis...@apache.org>
Subject Re: Review Request 39491: AMBARI-13442: stack advisor layout and validations for HAWQ service master components
Date Thu, 22 Oct 2015 00:04:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39491/
-----------------------------------------------------------

(Updated Oct. 22, 2015, 12:04 a.m.)


Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, Mahadev Konar, and
Oleksandr Diachenko.


Changes
-------

updated with code review fix


Bugs: AMBARI-13442
    https://issues.apache.org/jira/browse/AMBARI-13442


Repository: ambari


Description
-------

Introduced layout recommendations and validations for Apache HAWQ service master components.

Test cases use new test json files for input rather than hardcoding data in the test case
directly.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 501517f 
  ambari-server/src/test/python/stacks/2.3/common/hosts-1-host.json PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/common/hosts-3-hosts.json PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/common/services-hawq-1-host.json PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/common/services-hawq-3-hosts.json PRE-CREATION

  ambari-server/src/test/python/stacks/2.3/common/services-master_ambari_colo-3-hosts.json
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/common/services-master_standby_colo-3-hosts.json
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/common/services-nohawq-3-hosts.json PRE-CREATION

  ambari-server/src/test/python/stacks/2.3/common/services-normal-hawq-3-hosts.json PRE-CREATION

  ambari-server/src/test/python/stacks/2.3/common/services-normal-nohawq-3-hosts.json PRE-CREATION

  ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py e0c6d28 

Diff: https://reviews.apache.org/r/39491/diff/


Testing
-------

Added new and ran python unit tests:
----------------------------------------------------------------------
Total run:775
Total errors:0
Total failures:0
OK


File Attachments (updated)
----------------

updated with fix
  https://reviews.apache.org/media/uploaded/files/2015/10/22/b04e7344-e7d7-4577-aa34-d7850f5ef090__AMBARI-13442.patch.1


Thanks,

Alexander Denissov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message