ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Newton Alex" <na...@pivotal.io>
Subject Re: Review Request 39356: Adding Apache HAWQ to common services
Date Tue, 20 Oct 2015 00:19:12 GMT


> On Oct. 15, 2015, 8:44 p.m., Alejandro Fernandez wrote:
> > Looks good overall.

Thanks for the quick feedback Alejandro. I'll be submitting a new patch with the comments
incorporated soon.


> On Oct. 15, 2015, 8:44 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/hawq-site.xml,
line 71
> > <https://reviews.apache.org/r/39356/diff/1/?file=1099086#file1099086line71>
> >
> >     /tmp may not always be writable

/tmp is the best bet we have in case the user doesn't define one. We cannot assume any other
directory to be writable either.


> On Oct. 15, 2015, 8:44 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/common.py,
line 55
> > <https://reviews.apache.org/r/39356/diff/1/?file=1099088#file1099088line55>
> >
> >     Why is this allowed to ignore failures?

I think this was to overcome an error msg we were getting when we set it to False

```
if getattr(self.resource, option_name) != None and getattr(self.resource, option_name) !=
attributes[0](self): File "/usr/lib/python2.6/site-packages/resource_management/core/providers/accounts.py",
line 38, in <lambda> password=(lambda self: self.user.pw_password, "-p"), AttributeError:
'pwd.struct_passwd' object has no attribute 'pw_password'
```


> On Oct. 15, 2015, 8:44 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/utils.py,
line 26
> > <https://reviews.apache.org/r/39356/diff/1/?file=1099097#file1099097line26>
> >
> >     Can any of these functions move up to ambari-common so they can be shared?

I looked at them, but dont think any of these would be useful at ambari-common. If you have
any particular function in mind pls let me know.


> On Oct. 15, 2015, 8:44 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/constants.py,
line 41
> > <https://reviews.apache.org/r/39356/diff/1/?file=1099089#file1099089line41>
> >
> >     FYI, I believe this is available in RHEL7 but not RHEL6. You can drop this if
it's not an issue.

I think it is available in RHEL6 because we do most of the testing on RHEL/CentOS6. It is
not available in SUSE though, so we have separate logic for that.


- Newton


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39356/#review102817
-----------------------------------------------------------


On Oct. 15, 2015, 8:07 p.m., Newton Alex wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39356/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2015, 8:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Mahadev Konar, and Oleksandr
Diachenko.
> 
> 
> Bugs: AMBARI-12320
>     https://issues.apache.org/jira/browse/AMBARI-12320
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Adding Apache HAWQ to common services
> 
> 
> Diffs
> -----
> 
>   ambari-server/pom.xml 17e9ea9 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/gpcheck-env.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/hawq-site.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/metainfo.xml PRE-CREATION

>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/common.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/constants.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqmaster.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqsegment.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqstandby.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqstatus.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/master_helper.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/params.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/service_check.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/utils.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq-hosts.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq-profile.sh.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq.limits.conf.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq.sysctl.conf.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/slaves.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0.0/metainfo.xml PRE-CREATION

>   ambari-server/src/main/resources/common-services/PXF/3.0.0.0/package/scripts/pxfservice.py
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39356/diff/
> 
> 
> Testing
> -------
> 
> Adding support for Apache HAWQ (http://hawq.incubator.apache.org/) in Ambari
> 
> 
> Thanks,
> 
> Newton Alex
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message