ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Re: Review Request 39395: RegionServer Upgrade verification is not case sensitive
Date Fri, 16 Oct 2015 14:52:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39395/
-----------------------------------------------------------

(Updated Oct. 16, 2015, 2:52 p.m.)


Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-13452
    https://issues.apache.org/jira/browse/AMBARI-13452


Repository: ambari


Description
-------

Reference . During RU, there was an issue when upgrading RegionServers, in
that the check for RS being up was reporting failed. The output of the hbase
shell command was returning host names in uppercase, where Ambari used lower
case names for the hostname (and check). The following commented codes shows
the problem:

In common-services/HBASE/0.96.0.2.0/package/scripts/upgrade.py:

    
    
    
    def post_regionserver(env):
      import params
      env.set_params(params)
    
      check_cmd = "echo 'status \"simple\"' | {0} shell".format(params.hbase_cmd)
    
      exec_cmd = "{0} {1}".format(params.kinit_cmd, check_cmd)
      call_and_match(exec_cmd, params.hbase_user, params.hostname.lower() + ":")  # hostname
is lower case already
    
    
    @retry(times=15, sleep_time=2, err_class=Fail)
    def call_and_match(cmd, user, regex):
    
      code, out = shell.call(cmd, user=user)          # out contains hostnames capitalized
    
      if not (out and re.search(regex, out)):
        raise Fail("Could not verify RS available")


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/upgrade.py
a9ccede 

Diff: https://reviews.apache.org/r/39395/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message