ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 39319: Distributing patch repo bits should target specific hosts
Date Wed, 14 Oct 2015 16:51:25 GMT


> On Oct. 14, 2015, 12:32 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java,
lines 596-606
> > <https://reviews.apache.org/r/39319/diff/1/?file=1098362#file1098362line596>
> >
> >     This method seems to no longer send an event out for other hosts which require
the repo; is that on purpose?

I was trying to to think about how the transition business would change and didn't put it
back.  I'll hack back in the NOT_REQUIRED code to get it working.


> On Oct. 14, 2015, 12:32 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java,
lines 1246-1247
> > <https://reviews.apache.org/r/39319/diff/1/?file=1098365#file1098365line1246>
> >
> >     What's with the caps?

Consistency :)  Will fix to normal names.


> On Oct. 14, 2015, 12:32 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java,
lines 1202-1215
> > <https://reviews.apache.org/r/39319/diff/1/?file=1098365#file1098365line1202>
> >
> >     Maybe add some information here that the NOT_REQUIRED state shouldn't be returned
and that it's used to determine INSTALLED vs INSTALLING?

Will do.


> On Oct. 14, 2015, 12:32 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java,
lines 590-595
> > <https://reviews.apache.org/r/39319/diff/1/?file=1098362#file1098362line590>
> >
> >     Change doc to reflect the new NOT_REQUIRED state.

Will do.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39319/#review102642
-----------------------------------------------------------


On Oct. 14, 2015, 12:19 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39319/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 12:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-13423
>     https://issues.apache.org/jira/browse/AMBARI-13423
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When distributing bits, and the repo is targeting components for patching, then only
send the command to those hosts.
> 
> NOTES:
> - This is on a feature branch, made sure tests were functional
> - Added a new repo state, a separate effort is ongoing for the transition logic
> - The branch is NOT YET merged with the trunk changes for EU.  Once that settles, that
will be brought in.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/PersistKeyValueService.java
9b942e5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
4868ca7 
>   ambari-server/src/main/java/org/apache/ambari/server/events/ActionFinalReportReceivedEvent.java
de797f3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java
b0f85b4 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
e3bb320 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
1819ef9 
> 
> Diff: https://reviews.apache.org/r/39319/diff/
> 
> 
> Testing
> -------
> 
> Manual testing, automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message