ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 39121: AMBARI-13346 : More relevant error messages should be provided for Ranger password issues
Date Fri, 09 Oct 2015 17:36:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39121/#review102089
-----------------------------------------------------------



ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py
(line 76)
<https://reviews.apache.org/r/39121/#comment159603>

    Please add some pydoc to all of these functions.



ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py
(line 91)
<https://reviews.apache.org/r/39121/#comment159602>

    Does this need to check that "name" is in repo?


- Alejandro Fernandez


On Oct. 8, 2015, 10:19 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39121/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 10:19 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty,
Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-13346
>     https://issues.apache.org/jira/browse/AMBARI-13346
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch contains corrections in error messages given based on different error responses
from Ranger REST calls.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py
e4b1744 
>   ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
253ee03 
> 
> Diff: https://reviews.apache.org/r/39121/diff/
> 
> 
> Testing
> -------
> 
> Tested on a cluster having Ranger and HDFS for Error responses of cases like: 
> 
> 1) Ranger Host not reachable
> 2) Invalid Password
> 3) Service create failed
> 
> ----------------------------------------------------------------------
> Ran 264 tests in 6.590s
> 
> OK
> ----------------------------------------------------------------------
> Total run:838
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message