ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Re: Review Request 39175: Prioritize point in time queries to JMX endpoints
Date Fri, 09 Oct 2015 16:27:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39175/#review102074
-----------------------------------------------------------



ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
(line 966)
<https://reviews.apache.org/r/39175/#comment159596>

    This test looks great. Need sign off from UI team on the changes made, rest looks good.
I presume the edits to Json files are duplicate ams metrics being removed or marked temporal
only, right?


- Sid Wagle


On Oct. 9, 2015, 3:42 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39175/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 3:42 p.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13376
>     https://issues.apache.org/jira/browse/AMBARI-13376
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Find all point in time queries supported by both JMX and AMS
> Priority order is JMX first, so all quries should goto JMX first and then remaining to
AMS
> The JMX data is latest and should be the only source of truth for point in time queries
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
04c1c19 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java
d0d597e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java
eeb0762 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 832370d

>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/Metric.java ef2e7c6

>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metrics.json 5e5e775

>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metrics.json 7376d82

>   ambari-server/src/main/resources/jmx_properties.json 69b8d75 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/metrics.json e591970

>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
cf7c8cd 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java
cafbc6f 
>   ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java 90cb913

>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
6318552 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java
3ba79ca 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java
18dcea1 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
174d489 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/JdbcPropertyTest.java 0b1f41e

>   ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationTestModule.java
bdf5a6f 
>   ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationTestModuleForLdapDNWithSpace.java
d37513e 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java fced888

>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeTest.java 405e6f7

> 
> Diff: https://reviews.apache.org/r/39175/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message