ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Re: Review Request 38890: Define a new API to refresh HDP.repo files using the provided repo baseurl
Date Thu, 08 Oct 2015 19:00:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38890/#review101949
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
(line 205)
<https://reviews.apache.org/r/38890/#comment159458>

    Why do we need to remove this check. This is applied when the action definition has TargetHostType
as Specific. If its not then this check will not be called.


- Sumit Mohanty


On Oct. 8, 2015, 3:13 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38890/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 3:13 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, and Sumit
Mohanty.
> 
> 
> Bugs: AMBARI-13274
>     https://issues.apache.org/jira/browse/AMBARI-13274
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Even though in the AmbariUI (Ambari >> Admin >> Manage Ambari >> versions
>> click on the correct version) you have the correct repos. The HDP.repo/repoinfo.xml
file doesn't get updated in the agent nodes even after restart of ambari-server and ambari-agents.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
1c110fc 
>   ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml
777ced7 
>   ambari-server/src/main/resources/custom_actions/scripts/update_repo.py PRE-CREATION

>   ambari-server/src/test/python/custom_actions/TestUpdateRepo.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38890/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message