ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 39133: Ambari throwing ganglia errors after upgrade
Date Thu, 08 Oct 2015 16:44:08 GMT


> On Oct. 8, 2015, 10:55 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java, line
567
> > <https://reviews.apache.org/r/39133/diff/1/?file=1093188#file1093188line567>
> >
> >     How about deleting these entries.
> 
> Myroslav Papirkovskyy wrote:
>     clusterconfigmapping table contains audit information, including time when config
was enabled and name of user who made changes. 
>     This may be useful for some analisys and as historical data.
>     Usually we don't remove old configs (there are some exceptions during RU), and removing
mentioned info also seems to be wrong.
> 
> Sumit Mohanty wrote:
>     In that case, is there a need to remove configs from clusterconfig table? perhaps
we should revisit the fix for https://issues.apache.org/jira/browse/AMBARI-13144

I agree that we should probably preserve them for audit history. But I also don't think we
should be keeping the old configurations in clusterconfig; the service is gone and its configuration
is meaningless. If you decide to add the service back later on, the old configs could be confusing.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39133/#review101913
-----------------------------------------------------------


On Oct. 8, 2015, 10:50 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39133/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 10:50 a.m.)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-13358
>     https://issues.apache.org/jira/browse/AMBARI-13358
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Teradata are seeing the following errors getting spammed in the ambari-
> server.log after an upgrade. Ganglia has been removed from ambari and there is
> no ganglia-env configuration in ambari. This is running the latest HDP 2.3.2
> and ambari 2.1.2.
> 
>     
>     
>     30 Sep 2015 20:07:57,038 ERROR [ambari-hearbeat-monitor] ClusterImpl:2016 - Config
inconsistency exists: unknown configType=ganglia-env
>     30 Sep 2015 20:07:57,039 ERROR [ambari-hearbeat-monitor] ClusterImpl:2016 - Config
inconsistency exists: unknown configType=ganglia-env
>     30 Sep 2015 20:07:57,039 ERROR [ambari-hearbeat-monitor] ClusterImpl:2016 - Config
inconsistency exists: unknown configType=ganglia-env
>     30 Sep 2015 20:07:57,040 ERROR [ambari-hearbeat-monitor] ClusterImpl:2016 - Config
inconsistency exists: unknown configType=ganglia-env
>     30 Sep 2015 20:07:57,040 ERROR [ambari-hearbeat-monitor] ClusterImpl:2016 - Config
inconsistency exists: unknown configType=ganglia-env
>     30 Sep 2015 20:07:57,041 ERROR [ambari-hearbeat-monitor] ClusterImpl:2016 - Config
inconsistency exists: unknown configType=ganglia-env
>     30 Sep 2015 20:07:57,041 ERROR [ambari-hearbeat-monitor] ClusterImpl:2016 - Config
inconsistency exists: unknown configType=ganglia-env
>     30 Sep 2015 20:07:57,042 ERROR [ambari-hearbeat-monitor] ClusterImpl:2016 - Config
inconsistency exists: unknown configType=ganglia-env
>     30 Sep 2015 20:07:57,042 ERROR [ambari-hearbeat-monitor] ClusterImpl:2016 - Config
inconsistency exists: unknown configType=ganglia-env
>     30 Sep 2015 20:07:57,043 ERROR [ambari-hearbeat-monitor] ClusterImpl:2016 - Config
inconsistency exists: unknown configType=ganglia-env
>     ….
>     30 Sep 2015 20:08:22,806 ERROR [qtp-client-27] ClusterImpl:2016 - Config inconsistency
exists: unknown configType=ganglia-env
>     30 Sep 2015 20:08:22,807 ERROR [qtp-client-27] ClusterImpl:2016 - Config inconsistency
exists: unknown configType=ganglia-env
>     30 Sep 2015 20:08:22,808 ERROR [qtp-client-27] ClusterImpl:2016 - Config inconsistency
exists: unknown configType=ganglia-env
>     30 Sep 2015 20:08:23,133 ERROR [pool-7-thread-1340] ClusterImpl:2016 - Config inconsistency
exists: unknown configType=ganglia-env
>     30 Sep 2015 20:08:23,133 ERROR [pool-7-thread-1337] ClusterImpl:2016 - Config inconsistency
exists: unknown configType=ganglia-env
>     30 Sep 2015 20:08:23,134 ERROR [pool-7-thread-1336] ClusterImpl:2016 - Config inconsistency
exists: unknown configType=ganglia-env
>     30 Sep 2015 20:08:23,136 ERROR [pool-7-thread-1335] ClusterImpl:2016 - Config inconsistency
exists: unknown configType=ganglia-env
>     30 Sep 2015 20:08:23,136 ERROR [pool-7-thread-1338] ClusterImpl:2016 - Config inconsistency
exists: unknown configType=ganglia-env
>      
> 
> We don’t see this on a fresh install of HDP 2.3.2 and ambari 2.1.2
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 6e55128

>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java c210557

> 
> Diff: https://reviews.apache.org/r/39133/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message