ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 39052: Ambari-server upgrade and RU update hbase bucket cache setting incorrectly
Date Wed, 07 Oct 2015 15:53:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39052/#review101771
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java (line
175)
<https://reviews.apache.org/r/39052/#comment159263>

    Documentation.



ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java (line
185)
<https://reviews.apache.org/r/39052/#comment159264>

    Documentation.



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java (lines
52 - 53)
<https://reviews.apache.org/r/39052/#comment159266>

    Not that I'm against using constants for reusable values, I'm not sure this is necessary.
If you wanted to make this static, then maybe scope it more to it's use; like call it NIMBUS_MONITORING_FREQ_SECONDS
or something.



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java (line
130)
<https://reviews.apache.org/r/39052/#comment159265>

    Easier to read if we just use StringUtils for this - avoids the double checks for null
and equality.


- Jonathan Hurley


On Oct. 7, 2015, 7:48 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39052/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 7:48 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav Papirkovskyy,
Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-13325
>     https://issues.apache.org/jira/browse/AMBARI-13325
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> PROBLEM: Ambari update the below setting in hbase-site:
> hbase.bucketcache.ioengine=offheap
> hbase.bucketcache.percentage.in.combinedcache= 
> hbase.bucketcache.size=10240
> But there is no setting in hbase-env for 
> -XX:MaxDirectMemorySize
> so when restart HBase Region server, it fails
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61

>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
62cd868 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java
dcdbb85 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java
a54dee2 
> 
> Diff: https://reviews.apache.org/r/39052/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message