ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 39063: Service and Component info for repo_versions
Date Wed, 07 Oct 2015 00:17:50 GMT


> On Oct. 6, 2015, 8 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java,
lines 495-498
> > <https://reviews.apache.org/r/39063/diff/1/?file=1092057#file1092057line495>
> >
> >     Is this our normal model; or do we normally return an empty array? An empty
array would probably help the UI avoid JavaScript issues.

This is on create(/edit) - either the UI is going to supply the array or they aren't.


> On Oct. 6, 2015, 8 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java,
line 29
> > <https://reviews.apache.org/r/39063/diff/1/?file=1092060#file1092060line29>
> >
> >     "STANDARD" or "NORMAL" or "ALL"?

meh :)


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39063/#review101717
-----------------------------------------------------------


On Oct. 6, 2015, 5:55 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39063/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 5:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-13326
>     https://issues.apache.org/jira/browse/AMBARI-13326
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Adds service and component definitions to the repository endpoint.
> 
> NOTE:  UpgradeCatalog* classes aren't updated with schema changes.  I'll do that as a
separate JIRA near the end.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
06291dd 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java
4ac1314 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
dafd4b2 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java PRE-CREATION

>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1511385 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql a3c1625 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 2636eef 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql d515fa6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 807ccd5 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1f95f0f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
41d0175 
> 
> Diff: https://reviews.apache.org/r/39063/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:
> 
> Tests run: 3258, Failures: 0, Errors: 0, Skipped: 25
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:27 min
> [INFO] Finished at: 2015-10-06T14:48:25-07:00
> [INFO] Final Memory: 35M/1300M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message