ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Di Li" <d...@ca.ibm.com>
Subject Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if use another server as ambari-server next time
Date Mon, 05 Oct 2015 15:37:43 GMT


> On Oct. 2, 2015, 11:16 p.m., Andrew Onischuk wrote:
> > ambari-agent/src/main/package/rpm/postremove.sh, line 25
> > <https://reviews.apache.org/r/38806/diff/3/?file=1089135#file1089135line25>
> >
> >     Di, 
> >     
> >     Why we are deleting this directory, shouldn't it get deleted automatically with
rpm deleting?-helper.sh?

Hello Andrew,

I removed the postremove.sh for agents as it's not needed anymore, since the ambari-agent
dir in python2.6/site-packages is removed per rpm uninstall. For ambari-server though, I kept
the postremove.sh as the ambari-server dir was left in python2.6/site-packages after the rpm
removal.


- Di


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/#review101389
-----------------------------------------------------------


On Oct. 2, 2015, 10:07 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38806/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 10:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
> 
> 
> Bugs: AMBARI-13242
>     https://issues.apache.org/jira/browse/AMBARI-13242
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages.
The broken links causes following err if user tries to install Ambari server on a node that
has been previously installed with Ambari agent. Vise Versa.
> 
> File "/usr/sbin/ambari-server.py", line 26, in <module>
> from ambari_commons.exceptions import FatalException, NonFatalException
> File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data
> 
> 
> Diffs
> -----
> 
>   ambari-agent/conf/unix/install-helper.sh 35c67fb 
>   ambari-agent/pom.xml 0096162 
>   ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION 
>   ambari-server/conf/unix/install-helper.sh 9dbb2b8 
>   ambari-server/pom.xml 3377961 
>   ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38806/diff/
> 
> 
> Testing
> -------
> 
> Generate Ambari Server and Agent RPMs
> Install the Ambari Agent RPM on a machine
> Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages
are removed. 
> On the very same machine, now install Ambari Server RPM > verify the RPM install is
successful, and can start/stop Ambari server.
> Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages
are removed.
> 
> 
> Thanks,
> 
> Di Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message