ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 38938: Integrate Hive with Atlas in Blueprints
Date Fri, 02 Oct 2015 16:01:11 GMT


> On Oct. 2, 2015, 1:21 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java,
line 2064
> > <https://reviews.apache.org/r/38938/diff/1/?file=1088755#file1088755line2064>
> >
> >     Why should this property be removed, is this an Atlas config property that will
eventually go away?

Yes, this property should be removed from the hive configuration shortly.


> On Oct. 2, 2015, 1:21 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java,
line 2072
> > <https://reviews.apache.org/r/38938/diff/1/?file=1088755#file1088755line2072>
> >
> >     Shouldn't this default be defined in the stacks somewhere?

Good catch Bob.  Seems that I may be looking at the wrong config property.  I will change
to use the correct defaults from config.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38938/#review101315
-----------------------------------------------------------


On Oct. 1, 2015, 10:03 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38938/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2015, 10:03 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton and Sid Wagle.
> 
> 
> Bugs: AMBARI-13129
>     https://issues.apache.org/jira/browse/AMBARI-13129
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Allow Hive and Atlas to be integrated by Ambari automatically when deploying via a blueprint.
> - Introduce a new Atlas client component in the HDP stack which will be used for all
Atlas service integration
> - Set/Update the appropriate properties when Hive and Atlas are both included in the
cluster topology
> 
> The end result of this work will be seamless integration of Hive and Atlas when deployed
via a blueprint. The user will simply need to include the appropriate Hive and Atlas components
and all configuration/integration is done automatically by Ambari.
> 
> This patch doesn't include any component depencency between HIVE and the ATLAS client
so if the user doesn't specify an ATLAS client on the HIVE nodes, then they will need to manually
configure the hive/atlas configurations.  This is because Ambari doesn't directly support
conditional dependencies.  This should be added in another patch so that the ATLAS client
is added as necessary to the blueprint during topology validation.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
892cf32 
>   ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml a77bad3

>   ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
a97ca74 
> 
> Diff: https://reviews.apache.org/r/38938/diff/
> 
> 
> Testing
> -------
> 
> Functional Testing:
> - Deployed clusters via blueprint with different topologies containing both Hive and
Atlas.
> - In the process of UI test to ensure that addition of ATLAS_CLIENT doesn't cause issues.
> 
> Unit Tests:
> - Added new unit tests for BP config processor changes
> - In the process of running full suite if unit tests
> 
> Will update the review with the above in-progress testing prior to merging.
> 
> Results :
> 
> Tests run: 3240, Failures: 0, Errors: 0, Skipped: 25
> ...
> Total run:765
> Total errors:0
> Total failures:0
> ...
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 53:06 min
> [INFO] Finished at: 2015-10-01T17:53:26-04:00
> [INFO] Final Memory: 60M/1731M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message