ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andriy Babiichuk" <ababiic...@hortonworks.com>
Subject Re: Review Request 38921: Enhanced Configs ui work to add Ranger User Info tab
Date Fri, 02 Oct 2015 11:41:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38921/
-----------------------------------------------------------

(Updated Окт. 2, 2015, 11:41 д.п.)


Review request for Ambari, Jaimin Jetly and Oleg Nechiporenko.


Bugs: AMBARI-13280
    https://issues.apache.org/jira/browse/AMBARI-13280


Repository: ambari


Description
-------

Currently, there is a notion of tab, section and subsection in UI which is completely theme
driven from stack API endpoint.
subsection is the last container that contains set of configs. This is achieved by registering
each config with a subsection in service theme.
As part of this ticket add a notion of subsection-tabs (a group of tabs) which can be optionally
present inside a subsection. Any config can register only to a subsection as it does currently
or can register to a subsection and to an individual tab of a subsection-tab located inside
the subsection.
For now, Layout of a subsection-tabs (a group of tabs) in a subsection is always at last.
This means that if there are configs that are not mapped to any individual tab of subsection-tabs
then they will be placed before subsection-tabs. Orientation of configs inside subsection-tabs
should be in order of their occurrence in theme.json.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigPlacement.java 56d2ea282e14c78c47badaaa0672799ffd739231

  ambari-server/src/main/java/org/apache/ambari/server/state/theme/Subsection.java 039754514d0e39c287790527fb034a164f500c43

  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml
97ba241afb4358eb34b905f9e5249945cfc5f5bf 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml
7f3e6e062b3b66c950d64eafe191cb7421cf6602 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml
de63dd678cdab8aa2bcda3033888f4070fcc0bbb 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme.json 7160a4f691dda0a6ad79d5e57c055de4f1090822

  ambari-web/app/controllers/installer.js 194d86224af084631ad820258221ed9d30032c83 
  ambari-web/app/data/HDP2.3/site_properties.js 8495deededf3cec6ad876da4b42374e62b921dc3 
  ambari-web/app/mappers/configs/themes_mapper.js b55a695dd32ffffc1a08905dace6b41c7a19435b

  ambari-web/app/models.js 1b34b0c4b88733e9aec8a53dbab14f7980615211 
  ambari-web/app/models/configs/section.js c04665e84b4d13878942e8a92dd21dc201f20516 
  ambari-web/app/models/configs/stack_config_property.js 76e3b5f6ce9bc35df27e248a98e88febce8457cf

  ambari-web/app/models/configs/sub_section.js b7abb4fad96045ce840daf2341a808191915356a 
  ambari-web/app/models/configs/tab.js 0940022c94f361077deb00e31da532f099f9664f 
  ambari-web/app/models/configs/theme/section.js PRE-CREATION 
  ambari-web/app/models/configs/theme/sub_section.js PRE-CREATION 
  ambari-web/app/models/configs/theme/sub_section_tab.js PRE-CREATION 
  ambari-web/app/models/configs/theme/tab.js PRE-CREATION 
  ambari-web/app/templates/common/configs/service_config_layout_tab.hbs 69de31521eb43fbd50fc78cb6a8832adca6ad64d

  ambari-web/app/views/common/configs/service_config_layout_tab_view.js 6815a0ddc0450a1f2c5d543a71cd1538bc820f9e

  ambari-web/test/mappers/configs/themes_mapper_test.js 99456e0bb7ae4f8fefd411342a4986ba1dca57e0


Diff: https://reviews.apache.org/r/38921/diff/


Testing
-------

9083 tests complete (11 seconds)
95 tests pending


Thanks,

Andriy Babiichuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message