ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangeeta Ravindran" <sangeeta.e.ravind...@gmail.com>
Subject Re: Review Request 38732: AMBARI-12328: Background operations popup window does not use service display name for restart operations
Date Thu, 01 Oct 2015 17:49:19 GMT


> On Sept. 30, 2015, 7:08 a.m., Andriy Babiichuk wrote:
> > Ship It!

Thanks Andriy. Can you please help push the fix.


- Sangeeta


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38732/#review101093
-----------------------------------------------------------


On Sept. 24, 2015, 9:30 p.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38732/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 9:30 p.m.)
> 
> 
> Review request for Ambari and Andriy Babiichuk.
> 
> 
> Bugs: AMBARI-12328
>     https://issues.apache.org/jira/browse/AMBARI-12328
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> For most of the operations (start and stop), the service display name is used in the
popup that displays the status of background operations. 
> 
> For start all however, the service name is used. Need to use the service display name
instead.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/info/configs.js db5f1ed 
>   ambari-web/app/controllers/main/service/item.js 89fbb69 
>   ambari-web/app/utils/batch_scheduled_requests.js 95d8f9b 
>   ambari-web/app/views/main/service/info/summary.js 78855c0 
> 
> Diff: https://reviews.apache.org/r/38732/diff/
> 
> 
> Testing
> -------
> 
> Did manual verification of fix.
> Ran "mvn clean test" for ambari-web project and build ran successfully.
> 
> 9124 tests complete (14 seconds)
> 95 tests pending
> 
> No new tests needed, because there are test cases already defined for the function that
was modified. 
> 
> /ambari-web/test/views/main/service/info/summary_test.js
> /ambari-web/test/views/main/service/info/config_test.js
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message