Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0003C17729 for ; Wed, 2 Sep 2015 14:36:45 +0000 (UTC) Received: (qmail 77626 invoked by uid 500); 2 Sep 2015 14:36:45 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 77591 invoked by uid 500); 2 Sep 2015 14:36:45 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 77576 invoked by uid 99); 2 Sep 2015 14:36:45 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Sep 2015 14:36:45 +0000 Date: Wed, 2 Sep 2015 14:36:45 +0000 (UTC) From: "Greg Hill (JIRA)" To: dev@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-12916) Make API server hostname for views configurable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMBARI-12916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727430#comment-14727430 ] Greg Hill commented on AMBARI-12916: ------------------------------------ I looked for the tests, but apparently we don't have any tests for this module that involve overriding config values. We just mock out the method that I modified entirely and make sure other dependent methods work as expected. I'll try to find another example of how we mock out the config file elsewhere and add some tests. Input appreciated if someone can point me to a good example. > Make API server hostname for views configurable > ----------------------------------------------- > > Key: AMBARI-12916 > URL: https://issues.apache.org/jira/browse/AMBARI-12916 > Project: Ambari > Issue Type: Improvement > Components: ambari-server, ambari-views > Affects Versions: 2.1.0 > Reporter: Greg Hill > Assignee: Greg Hill > Priority: Minor > Attachments: AMBARI-12916.patch > > > The views that need to get data from the Ambari API use the system hostname to connect to the Ambari API. The problem is that the API could be configured with an SSL cert for a domain name other than the system hostname, and if you connect to it using the hostname, you will get SSL validation errors. Simply adding an optional hostname to the Ambari configs that will be used here would make it much easier to work in this sort of setup. > https://github.com/apache/ambari/blob/4c73ea906d02df2c79ef76f5cf6fd2b94ea78ca6/ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java#L299 -- This message was sent by Atlassian JIRA (v6.3.4#6332)