Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============0449042266065356395=="
MIME-Version: 1.0
Subject: Re: Review Request 38802: configs.sh cannot add name-value pair to an
 empty config
From: "Dmytro Sen" <dsen@hortonworks.com>
To: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>,
 "Vitalyi Brodetskyi" <vbrodetskyi@hortonworks.com>
Cc: "Sumit Mohanty" <smohanty@hortonworks.com>,
 "Dmytro Sen" <dsen@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Mon, 28 Sep 2015 14:32:05 -0000
Message-ID: <20150928143205.1944.46267@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Dmytro Sen" <noreply@reviews.apache.org>
References: <20150928110507.1943.31541@reviews.apache.org>
In-Reply-To: <20150928110507.1943.31541@reviews.apache.org>
Reply-To: "Dmytro Sen" <dsen@hortonworks.com>

--===============0449042266065356395==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38802/
-----------------------------------------------------------

(Updated Сен. 28, 2015, 2:32 п.п.)


Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi.


Bugs: AMBARI-13256
    https://issues.apache.org/jira/browse/AMBARI-13256


Repository: ambari


Description
-------

slider-client by default is an empty config.
Using configs.sh to add a name-value pair fails.
[root@c6401 vagrant]# /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client slider.yarn.queue system
########## Performing 'set' slider.yarn.queue:system on (Site:slider-client, Tag:version1)
########## PUTting json into: doSet_version1442967870900626075.json
{
  "status" : 400,
  "message" : "Invalid Request: Malformed Request Body.  An exception occurred parsing the request body: Unexpected character ('}' (code 125)): was expecting double-quote to start field name\n at [Source: java.io.StringReader@3b1cbed6; line: 1, column: 99]"
}########## NEW Site:slider-client, Tag:version1
The work-around is to use the CONFIG_FILENAME option.
[root@c6401 vagrant]# cat set_slider_client.json
"properties" : {"slider.yarn.queue" : "system" }
/var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client set_slider_client.json
After that you can add different name-value pairs but not what you just added. This is not common but should be tested as part of the fix.
[root@c6401 vagrant]# /var/lib/ambari-server/resources/scripts/configs.sh set localhost c1 slider-client slider.yarn.queue system
########## Performing 'set' slider.yarn.queue:system on (Site:slider-client, Tag:version1442968406632940163)
########## Config found. Skipping origin value
########## PUTting json into: doSet_version1442968426333905754.json
{
  "status" : 400,
  "message" : "Invalid Request: Malformed Request Body.  An exception occurred parsing the request body: Unexpected character (',' (code 44)): was expecting double-quote to start field name\n at [Source: java.io.StringReader@4b51dc38; line: 1, column: 115]"
}########## NEW Site:slider-client, Tag:version1442968406632940163


Diffs (updated)
-----

  ambari-server/src/main/resources/scripts/configs.sh a32ff42 

Diff: https://reviews.apache.org/r/38802/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


--===============0449042266065356395==--