Return-Path: 
 <dev-return-88722-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 584E217A88
	for <apmail-ambari-dev-archive@www.apache.org>;
 Mon, 28 Sep 2015 12:49:01 +0000 (UTC)
Received: (qmail 90389 invoked by uid 500); 28 Sep 2015 12:48:55 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 90354 invoked by uid 500); 28 Sep 2015 12:48:55 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 90339 invoked by uid 99); 28 Sep 2015 12:48:54 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Sep 2015 12:48:54 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 10AAA274A0E;
	Mon, 28 Sep 2015 12:48:52 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============2637870120316690620=="
MIME-Version: 1.0
Subject: Re: Review Request 38806: AMBARI-13242: ambari-server setup failed if
 use another server as ambari-server next time
From: "Di Li" <dili@ca.ibm.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>
Cc: "Di Li" <dili@ca.ibm.com>, "Ambari" <dev@ambari.apache.org>
Date: Mon, 28 Sep 2015 12:48:52 -0000
Message-ID: <20150928124852.1944.31372@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Di Li" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/38806/
X-Sender: "Di Li" <noreply@reviews.apache.org>
References: <20150928124819.1943.32659@reviews.apache.org>
In-Reply-To: <20150928124819.1943.32659@reviews.apache.org>
Reply-To: "Di Li" <dili@ca.ibm.com>
X-ReviewRequest-Repository: ambari

--===============2637870120316690620==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38806/
-----------------------------------------------------------

(Updated Sept. 28, 2015, 12:48 p.m.)


Review request for Ambari and Alejandro Fernandez.


Summary (updated)
-----------------

AMBARI-13242: ambari-server setup failed if use another server as ambari-server next time


Bugs: AMBARI-13242
    https://issues.apache.org/jira/browse/AMBARI-13242


Repository: ambari


Description
-------

The uninstall script in RPM does not clean up the symbolic links created in /usr/lib/python2.6/site-packages. The broken links causes following err if user tries to install Ambari server on a node that has been previously installed with Ambari agent. Vise Versa.

File "/usr/sbin/ambari-server.py", line 26, in <module>
from ambari_commons.exceptions import FatalException, NonFatalException
File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in <module>
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, in <module>
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, in _init_
File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, in initialize_data


Diffs
-----

  ambari-agent/pom.xml 0096162 
  ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION 
  ambari-server/pom.xml 3377961 
  ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/38806/diff/


Testing
-------

Generate Ambari Server and Agent RPMs
Install the Ambari Agent RPM on a machine
Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed. 
On the very same machine, now install Ambari Server RPM > verify the RPM install is successful, and can start/stop Ambari server.
Run yum erase to remove the Ambari Server RPM > verify the symbolic links in /usr/lib/python2.6/site-packages are removed.


Thanks,

Di Li


--===============2637870120316690620==--