Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3E5AC177E1 for ; Sun, 27 Sep 2015 06:52:08 +0000 (UTC) Received: (qmail 20816 invoked by uid 500); 27 Sep 2015 06:52:08 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 20787 invoked by uid 500); 27 Sep 2015 06:52:08 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 20586 invoked by uid 99); 27 Sep 2015 06:52:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Sep 2015 06:52:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E4B141DB7B5; Sun, 27 Sep 2015 06:52:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2329311864302293093==" MIME-Version: 1.0 Subject: Re: Review Request 38748: AMBARI-11967: Oozie db password appears in clear text in client config downloaded from Ambari UI From: "Sangeeta Ravindran" To: "Andrew Onischuk" Cc: "Ambari" , "Sangeeta Ravindran" Date: Sun, 27 Sep 2015 06:52:04 -0000 Message-ID: <20150927065204.31021.29725@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sangeeta Ravindran" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38748/ X-Sender: "Sangeeta Ravindran" References: <20150925050919.31021.27230@reviews.apache.org> In-Reply-To: <20150925050919.31021.27230@reviews.apache.org> Reply-To: "Sangeeta Ravindran" X-ReviewRequest-Repository: ambari --===============2329311864302293093== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38748/ ----------------------------------------------------------- (Updated Sept. 27, 2015, 6:52 a.m.) Review request for Ambari and Andrew Onischuk. Bugs: AMBARI-11967 https://issues.apache.org/jira/browse/AMBARI-11967 Repository: ambari Description ------- When Oozie Client Configs are downloaded from the Ambari UI, the oozie-site.xml included in the tar.gz file contains the value of the oozie.service.JPAService.jdbc.password field. The password should not be included in the downloaded client config file. Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java dea0362 ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7643abb Diff: https://reviews.apache.org/r/38748/diff/ Testing ------- Manual testing. Updated JUnit test case. Ran mvn clean test. Thanks, Sangeeta Ravindran --===============2329311864302293093==--