Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============6917280483848450353=="
MIME-Version: 1.0
Subject: Re: Review Request 38433: Config changes w/ blueprint provisioning
 are not picked up
From: "Robert Nettleton" <rnettleton@hortonworks.com>
To: "Sumit Mohanty" <smohanty@hortonworks.com>,
 "Robert Nettleton" <rnettleton@hortonworks.com>
Cc: "Oliver Szabo" <oszabo@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Wed, 16 Sep 2015 15:13:58 -0000
Message-ID: <20150916151358.3774.51649@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Robert Nettleton" <noreply@reviews.apache.org>
References: <20150916134057.9550.99973@reviews.apache.org>
In-Reply-To: <20150916134057.9550.99973@reviews.apache.org>
Reply-To: "Robert Nettleton" <rnettleton@hortonworks.com>

--===============6917280483848450353==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38433/#review99226
-----------------------------------------------------------

Ship it!


Patch looks fine to me.  

Could you please update the review with a summary of the functional testing done to verify this change?  I'd request that at a minimum a multi-node cluster needs to be deployed successfully with this patch applied.  

Thanks.

- Robert Nettleton


On Sept. 16, 2015, 1:40 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38433/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2015, 1:40 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13099
>     https://issues.apache.org/jira/browse/AMBARI-13099
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Problem:
> 
> Installing a cluster with a blueprint that contains host group level configurations are not picked up during install time. Ambari UI complains to restart few services after installation which doesn't make sense.
> In the provided BP there are host group level config like: 
> {
> "hdfs-site" :
> { "dfs.datanode.data.dir" : "/hadoopfs/fs1/hdfs/datanode,/hadoopfs/fs2/hdfs/datanode" }
> },
> {
> "yarn-site" :
> { "yarn.nodemanager.local-dirs" : "/hadoopfs/fs1/yarn/nodemanager,/hadoopfs/fs2/yarn/nodemanager", "yarn.nodemanager.log-dirs" : "/hadoopfs/fs1/yarn/nodemanager/log,/hadoopfs/fs2/yarn/nodemanager/log" }
> }
> and those directories are not in use, but the default ones. Compared to Ambari 2.1.0 there is nothing wrong with the bp.
> 
> Summary: 
> 
> Restart can solve this issue, because *-site.xml are not updated, but correct configuration in the blueprint.
> 
> Cause:
> 
> In case of "forceRefreshConfigTagsBeforeExecution" parameter exists for createHostAction, the additional config parameters are skipped.
> 
> Solution:
> 
> Remove the code which add "forceRefreshConfigTagsBeforeExecution" parameter to the execution command.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java 20a6932 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a7f206a 
> 
> Diff: https://reviews.apache.org/r/38433/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed. (not contains any updated test)
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:13 h
> [INFO] Finished at: 2015-09-16T02:31:05+00:00
> [INFO] Final Memory: 47M/520M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


--===============6917280483848450353==--