Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============3127115278312691790=="
MIME-Version: 1.0
Subject: Re: Review Request 38257: UpgradeCatalogs should use integer
 specifiers
From: "Jonathan Hurley" <jhurley@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Nate Cole" <ncole@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Thu, 10 Sep 2015 19:14:18 -0000
Message-ID: <20150910191418.1695.93396@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Jonathan Hurley" <noreply@reviews.apache.org>
References: <20150910173655.1695.83819@reviews.apache.org>
In-Reply-To: <20150910173655.1695.83819@reviews.apache.org>
Reply-To: "Jonathan Hurley" <jhurley@hortonworks.com>

--===============3127115278312691790==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Sept. 10, 2015, 1:36 p.m., Alejandro Fernandez wrote:
> > Sounds like this may be an issue all over the code base. UpgradeCatalogs are particularly troublesome.
> > We should send a public announcement.
> 
> Nate Cole wrote:
>     Agreed.  This was specific to get upgrading working properly.

+1


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38257/#review98429
-----------------------------------------------------------


On Sept. 10, 2015, 12:05 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38257/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 12:05 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-13057
>     https://issues.apache.org/jira/browse/AMBARI-13057
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Every invocation of MessageFormat.format() should use a number specifier: {0,number,#} where a long is used to build queries.
> 
> This issue can occur with any Ambari DB when the cluster has 1000+ components. Therefore, there is a high risk of this problem occurring on a cluster with 200+ hosts (which translates to 1000+ components, assuming 5 components per host).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 1981514 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java c650ae7 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java b04515a 
> 
> Diff: https://reviews.apache.org/r/38257/diff/
> 
> 
> Testing
> -------
> 
> Manual testing of 1000+ node db.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 58:36 min
> [INFO] Finished at: 2015-09-10T12:03:18-04:00
> [INFO] Final Memory: 34M/657M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


--===============3127115278312691790==--