Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C143F1812B for ; Thu, 10 Sep 2015 16:05:30 +0000 (UTC) Received: (qmail 76297 invoked by uid 500); 10 Sep 2015 16:05:30 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 76266 invoked by uid 500); 10 Sep 2015 16:05:30 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 76251 invoked by uid 99); 10 Sep 2015 16:05:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Sep 2015 16:05:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8F8502726B1; Thu, 10 Sep 2015 16:05:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0127851775020879381==" MIME-Version: 1.0 Subject: Re: Review Request 38257: UpgradeCatalogs should use integer specifiers From: "Nate Cole" To: "Alejandro Fernandez" , "Jonathan Hurley" Cc: "Nate Cole" , "Ambari" Date: Thu, 10 Sep 2015 16:05:29 -0000 Message-ID: <20150910160529.12751.73669@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Nate Cole" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38257/ X-Sender: "Nate Cole" References: <20150910152158.1695.90708@reviews.apache.org> In-Reply-To: <20150910152158.1695.90708@reviews.apache.org> Reply-To: "Nate Cole" X-ReviewRequest-Repository: ambari --===============0127851775020879381== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38257/ ----------------------------------------------------------- (Updated Sept. 10, 2015, 12:05 p.m.) Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs: AMBARI-13057 https://issues.apache.org/jira/browse/AMBARI-13057 Repository: ambari Description ------- Every invocation of MessageFormat.format() should use a number specifier: {0,number,#} where a long is used to build queries. This issue can occur with any Ambari DB when the cluster has 1000+ components. Therefore, there is a high risk of this problem occurring on a cluster with 200+ hosts (which translates to 1000+ components, assuming 5 components per host). Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 1981514 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java c650ae7 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java b04515a Diff: https://reviews.apache.org/r/38257/diff/ Testing (updated) ------- Manual testing of 1000+ node db. [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 58:36 min [INFO] Finished at: 2015-09-10T12:03:18-04:00 [INFO] Final Memory: 34M/657M [INFO] ------------------------------------------------------------------------ Thanks, Nate Cole --===============0127851775020879381==--