Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BDC311787A for ; Tue, 8 Sep 2015 13:30:14 +0000 (UTC) Received: (qmail 77709 invoked by uid 500); 8 Sep 2015 13:30:14 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 77670 invoked by uid 500); 8 Sep 2015 13:30:14 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 77656 invoked by uid 99); 8 Sep 2015 13:30:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Sep 2015 13:30:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BE75C271B0E; Tue, 8 Sep 2015 13:30:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2299090829371476061==" MIME-Version: 1.0 Subject: Review Request 38181: Automatically Skip Failed Tasks Of Slaves During Upgrade From: "Jonathan Hurley" To: "Alejandro Fernandez" , "Nate Cole" Cc: "Ambari" , "Jonathan Hurley" Date: Tue, 08 Sep 2015 13:30:13 -0000 Message-ID: <20150908133013.12751.86@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jonathan Hurley" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38181/ X-Sender: "Jonathan Hurley" Reply-To: "Jonathan Hurley" X-ReviewRequest-Repository: ambari --===============2299090829371476061== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38181/ ----------------------------------------------------------- Review request for Ambari, Alejandro Fernandez and Nate Cole. Bugs: AMBARI-13032 https://issues.apache.org/jira/browse/AMBARI-13032 Repository: ambari Description ------- During an upgrade, if any slave component experiences a failure during its restart state then there should be a way for the rest of the upgrade group to automatically continue despite the failure. This will prevent the need of administrators to babysit the upgrade process, especially in cases of larger clusters. During the creation of the upgrade, an optional parameter should be supplied to the REST endpoint to accomplish this. {code:title=POST api/v1/clusters/c1/upgrades} { "Upgrade": { "repository_version": "2.3.0.0-2545", "skip_failures": true } } {code} The various skippable parts of the upgrade can be broken out into distinct request parameters: - {{skip_failures}} (skips all component failures) - {{skip_service_check_failures}} (skips all service check failures) If an upgrade begins without the skip option specified, it can later be added: {code:title=PUT api/v1/clusters/c1/upgrades/1} { "Upgrade": { "skip_failures": true } } {code} Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 62f8be9 ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java 9d44454 ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommandFactory.java 84c2d2a ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommandFactoryImpl.java 0440f87 ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java 39cbabc ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java fcd0324 ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java ee5febe ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java a422b2d ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 43bdbfe ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a90cb31 ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f407c9 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a942c93 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1051056 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 770cc04 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 9c91656 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandStatusSummaryDTO.java 54ade92 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java d99da6d ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 86dbccd ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java b7f95cf ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java 02df181 ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 3da0fe2 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 265e42e ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 0053837 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 30b669d ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 4f7569c ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 97b5e11 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 81d0e6f ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 04befaf ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java 8d21b80 ambari-server/src/test/java/org/apache/ambari/server/actionmanager/StageTest.java fa1e770 ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 520be9f ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java 27f11f7 ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java cfbc38e ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestStage.java 13453df ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 4a4f8c9 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 4235ccd ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java 4700202 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java 0342bf2 ambari-server/src/test/java/org/apache/ambari/server/serveraction/ServerActionExecutorTest.java 193e3d5 ambari-server/src/test/java/org/apache/ambari/server/stageplanner/TestStagePlanner.java 0d36048 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java 7a394ca Diff: https://reviews.apache.org/r/38181/diff/ Testing ------- Thanks, Jonathan Hurley --===============2299090829371476061==--