ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangeeta Ravindran" <sangeeta.e.ravind...@gmail.com>
Subject Re: Review Request 38748: AMBARI-11967: Oozie db password appears in clear text in client config downloaded from Ambari UI
Date Sun, 27 Sep 2015 18:08:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38748/
-----------------------------------------------------------

(Updated Sept. 27, 2015, 6:08 p.m.)


Review request for Ambari and Andrew Onischuk.


Changes
-------

Fixed indentation. Removed try/catch block.


Bugs: AMBARI-11967
    https://issues.apache.org/jira/browse/AMBARI-11967


Repository: ambari


Description
-------

When Oozie Client Configs are downloaded from the Ambari UI, the oozie-site.xml included in
the tar.gz file contains the value of the oozie.service.JPAService.jdbc.password field.

The password should not be included in the downloaded client config file.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
dea0362 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 62c3b61 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
7643abb 

Diff: https://reviews.apache.org/r/38748/diff/


Testing
-------

Manual testing. Updated JUnit test case. Ran mvn clean test.


Thanks,

Sangeeta Ravindran


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message