ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Re: Review Request 38748: AMBARI-11967: Oozie db password appears in clear text in client config downloaded from Ambari UI
Date Fri, 25 Sep 2015 11:48:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38748/#review100573
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java (line
243)
<https://reviews.apache.org/r/38748/#comment157812>

    We shouldn't hardcode passwords in java code. This looks pretty hacky.
    
    <property-type>PASSWORD</property-type>
    
    The thing we should do is to grab all the properties with property-type password and exclude
them. 
    
    If you got any questions on implementing it. Please ping me aonishuk@hortonworks.com


- Andrew Onischuk


On Sept. 25, 2015, 5:09 a.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38748/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 5:09 a.m.)
> 
> 
> Review request for Ambari and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-11967
>     https://issues.apache.org/jira/browse/AMBARI-11967
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When Oozie Client Configs are downloaded from the Ambari UI, the oozie-site.xml included
in the tar.gz file contains the value of the oozie.service.JPAService.jdbc.password field.
> 
> The password should not be included in the downloaded client config file.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
e3686ac 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
dea0362 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
7643abb 
> 
> Diff: https://reviews.apache.org/r/38748/diff/
> 
> 
> Testing
> -------
> 
> Manual testing. Updated JUnit test case. Ran mvn clean test.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message