ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexandr Antonenko" <hiv...@gmail.com>
Subject Re: Review Request 38561: AMBARI-13154: Label of required fields in Details section of Create View Instance UI should include an asterisk
Date Fri, 25 Sep 2015 10:08:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38561/#review100569
-----------------------------------------------------------

Ship it!


Ship It!

- Alexandr Antonenko


On Sept. 21, 2015, 5:18 p.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38561/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 5:18 p.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-13154
>     https://issues.apache.org/jira/browse/AMBARI-13154
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When creating a view instance of any type of view, the instance name, display name and
description
> need to be entered. These fields are mandatory, but are not marked with an asterisk.
> 
> Since the fields under Cluster Configuration are marked with an asterisk if they are
mandatory,
> for consistency, the mandatory fields under Details section also be marked with an *.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html dffd66e

> 
> Diff: https://reviews.apache.org/r/38561/diff/
> 
> 
> Testing
> -------
> 
> Fix involves minor change in the string for labels. Manually tested the fix on trunk.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message